Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Total Followers to Total Subscribers #23113

Merged
merged 2 commits into from Apr 30, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Apr 29, 2024

Fixes #23099 (comment) since some string updates got merged for 24.8 and some didn't.

I'll trigger another beta today which will submit new strings to glotpress.

To test:

Check Stats -> Insights tab. Total Followers should be renamed to Total Subscribers.

total subscribers card total subscribers view

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 29, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@staskus staskus marked this pull request as draft April 29, 2024 10:37
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 29, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23113-3d6e3ce
Version24.8
Bundle IDcom.jetpack.alpha
Commit3d6e3ce
App Center Buildjetpack-installable-builds #8776
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 29, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23113-3d6e3ce
Version24.8
Bundle IDorg.wordpress.alpha
Commit3d6e3ce
App Center BuildWPiOS - One-Offs #9731
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @staskus!

There are other instances of "Followers" used instead of "Subscribers":

Do you prefer to update all of these now or merge this as-is?

@guarani
Copy link
Contributor

guarani commented Apr 29, 2024

I updated the only other instances of "Followers" on the Total Subscribers & Subscribers cards and their detail screens. There are more instances of "Followers" which I didn't update such as on the Jetpack Social Connections card, but I think this is out of scope.

@guarani guarani enabled auto-merge April 29, 2024 20:07
@guarani guarani merged commit 223b7c9 into release/24.8 Apr 30, 2024
24 checks passed
@guarani guarani deleted the fix/update-total-followers-translations branch April 30, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants