Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-App Updates: Show flexible update again after a specified interval #23221

Merged
merged 9 commits into from
May 22, 2024

Conversation

momo-ozawa
Copy link
Contributor

Part of https://github.com/Automattic/wordpress-mobile/issues/56

Description

Ref: p1715166447222309-slack-C072JBZL84U

  • Shows the flexible update again for a version after a specified interval

How to test

Preconditions

  • In Xcode, change the app version to something lower than the current app store version, e.g. 24.6
  • Enable the In-App Updates remote feature flag
  • Change delayInDays default value to 1

Test 1.1

  • Run on a real device
  • ✅ Verify the flexible update is displayed
  • Quit/reopen the app again
  • ✅ Verify the flexible update is NOT displayed
  1. Potential unintended areas of impact
    Flexible/blocking update logic

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Added a test

  3. What automated tests I added (or what prevented me from doing so)
    AppUpdateCoordinatorTests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23221-bec3387
Version24.9
Bundle IDcom.jetpack.alpha
Commitbec3387
App Center Buildjetpack-installable-builds #9013
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23221-bec3387
Version24.9
Bundle IDorg.wordpress.alpha
Commitbec3387
App Center BuildWPiOS - One-Offs #9963
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa force-pushed the task/iau-update-button-copy branch from 096c3a1 to 4612cd3 Compare May 17, 2024 10:01
@momo-ozawa
Copy link
Contributor Author

@kean - I made some changes to show the flexible update less often, as discussed in p1716217030223529-slack-C072JBZL84U. I'll ask to get the flexible update interval remote config value changed to 90 days.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested lastFetchedAppStoreInfoDate logic – works great, and I think it's a good addition 👍

Base automatically changed from task/iau-update-button-copy to trunk May 22, 2024 08:10
@momo-ozawa momo-ozawa enabled auto-merge May 22, 2024 08:18
@momo-ozawa momo-ozawa merged commit d28d7d1 into trunk May 22, 2024
24 checks passed
@momo-ozawa momo-ozawa deleted the task/iau-flexible-interval branch May 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants