In-App Updates: Add Version model #23224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23224-a45f6ae | |
| Version | 24.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a45f6ae | |
| App Center Build | WPiOS - One-Offs #9980 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23224-a45f6ae | |
| Version | 24.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a45f6ae | |
| App Center Build | jetpack-installable-builds #9030 |
momo-ozawa
force-pushed
the
task/iau-version
branch
from
07c8059
to
9cf33e8
Compare
kean
reviewed
May 22, 2024
| func isLowerThanOrEqual(to anotherVersionString: String) -> Bool { | ||
| [ComparisonResult.orderedSame, .orderedAscending].contains(self.compare(anotherVersionString, options: .numeric)) | ||
| extension Version { | ||
| init?(from versionString: String) { |
There was a problem hiding this comment.
(Nit) I would put this directly in the Version file`
| guard let version = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String else { | ||
| DDLogError("No CFBundleShortVersionString found in Info.plist") | ||
| guard let version = Bundle.main.infoDictionary?["CFBundleVersion"] as? String else { | ||
| DDLogError("No CFBundleVersion found in Info.plist") |
There was a problem hiding this comment.
(Nit) A good place for wpAssertionFailure.
There was a problem hiding this comment.
Fixed! 6b62951
| prereleaseIdentifiers: [String] = [], | ||
| buildMetadataIdentifiers: [String] = [] | ||
| ) { | ||
| precondition(major >= 0 && minor >= 0 && patch >= 0, "Negative versioning is invalid.") |
There was a problem hiding this comment.
I would suggest replacing precondition (crashes in prod) with safe failures and wpAssertionFailure.
momo-ozawa
force-pushed
the
task/iau-version
branch
from
9cf33e8
to
a45f6ae
Compare
|
@kean Thanks for reviewing - I've addressed all the comments. |
kean
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23195 (review)
Description
How to test
AppUpdateCoordinatorTestsis all greenRegression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: