Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow permanently deleting locally trashed drafts from the previous version of the app #23237

Merged
merged 1 commit into from
May 21, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 20, 2024

Fixes https://a8c.sentry.io/issues/5343807162/events/d9422391fc1247aba28b75b8fab16fb9/

To test:

Before testing: disable the assertion in PostRepository._delete on line 337

  • Turn network connectivity off
  • Disable the "Syncronous Publishing" FF
  • Open "Post List" / "Drafts"
  • Create and save a new draft
  • Tap "More" / "Trash" and confirm trashing
  • Enable the "Syncronous Publishing" FF
  • Restart the app
  • Open "Post List" / "Drafts" (the post will still be there)
  • Tap "More" / "Delete" (note: yes, it thinks it's in trash)
  • Verify that the post got deleted

Regression Notes

  1. Potential unintended areas of impact: Post List

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.9 ❄️ milestone May 20, 2024
@kean kean requested a review from momo-ozawa May 20, 2024 19:40
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.9 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23237-6b93f89
Version24.9
Bundle IDorg.wordpress.alpha
Commit6b93f89
App Center BuildWPiOS - One-Offs #9952
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23237-6b93f89
Version24.9
Bundle IDcom.jetpack.alpha
Commit6b93f89
App Center Buildjetpack-installable-builds #9002
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 06ff729 into release/24.9 May 21, 2024
25 of 27 checks passed
@kean kean deleted the fix/fallback-for-no-post-id-scenario branch May 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants