Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Update tags feature flag to be a remote flag #23241

Merged
merged 1 commit into from
May 23, 2024

Conversation

wargcm
Copy link
Contributor

@wargcm wargcm commented May 21, 2024

Description

Updates the local tags feed feature flag to a remote feature flag.

Testing

To test:

  • Launch Jetpack and login
  • Enable the tags feature flag
  • 馃攷 Verify the tags feed appears and works properly
  • Disable the feature flag
  • Restart the app
  • Relaunch and navigate to the Reader
  • 馃攷 Verify the tags feed feature does not appear

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A
    PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn鈥檛 complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wargcm wargcm added this to the 25.0 milestone May 21, 2024
@wargcm wargcm requested a review from dvdchr May 21, 2024 23:33
@wargcm wargcm self-assigned this May 21, 2024
@dangermattic
Copy link
Collaborator

1 Warning
鈿狅笍 View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 馃毇 Danger

@wargcm wargcm mentioned this pull request May 21, 2024
14 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 21, 2024

WordPress Alpha馃摬 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23241-0d6c57c
Version24.9
Bundle IDorg.wordpress.alpha
Commit0d6c57c
App Center BuildWPiOS - One-Offs #9978
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 21, 2024

Jetpack Alpha馃摬 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23241-0d6c57c
Version24.9
Bundle IDcom.jetpack.alpha
Commit0d6c57c
App Center Buildjetpack-installable-builds #9028
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wargcm wargcm force-pushed the task/tags-feed-remote-flag branch from eeac7c3 to 0d6c57c Compare May 23, 2024 01:44
@wargcm wargcm merged commit 92dc23d into trunk May 23, 2024
24 checks passed
@wargcm wargcm deleted the task/tags-feed-remote-flag branch May 23, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants