Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications Refresh] Introduce likes and subscribers details share button #23292

Merged

Conversation

justtwago
Copy link
Contributor

@justtwago justtwago commented May 31, 2024

Fixes https://github.com/Automattic/wordpress-mobile/issues/18

This PR introduces a footer with a share button for likes and subscribers notification details screens.

Subscribers Comment Likes Post Likes

To test:

  • Prepare three types of notifications: comment likes, post likes, and subscribers
  • Run the app and go to each notification and confirm all of them have a share button on the bottom of the screen
  • Ensure that the share button works properly by sharing a link with either a post, comment, or blog according to the notification type.

Regression Notes

  1. Potential unintended areas of impact
    Likes, Subscribers notification details screen

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual tests

  3. What automated tests I added (or what prevented me from doing so)
    Legacy code

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 31, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23292-ffe4c9b
Version24.8
Bundle IDorg.wordpress.alpha
Commitffe4c9b
App Center BuildWPiOS - One-Offs #10064
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 31, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23292-ffe4c9b
Version24.8
Bundle IDcom.jetpack.alpha
Commitffe4c9b
App Center Buildjetpack-installable-builds #9113
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa self-requested a review May 31, 2024 18:18
@salimbraksa salimbraksa self-requested a review May 31, 2024 18:51
Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@justtwago justtwago merged commit ce0c6b7 into feature/notifications_refresh_p2 Jun 3, 2024
24 checks passed
@justtwago justtwago deleted the feature/likes-details-share-button branch June 3, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants