Reconnect publicize from editor #6912
Conversation
If we don't propagate redirections, UIWebView gets all confused about what it just loaded. Specifically, when reconnecting a publicize connection from the post options, the REST API would redirect to facebook, but the web view would think it was showing public-api.wordpress.com, and everything breaks from Javascript to relative links.
| @@ -180,7 +174,37 @@ - (void)reconnectPublicizeConnection | |||
| return; | |||
| } | |||
|
|
|||
| [self.helper reconnectPublicizeConnection:self.publicizeConnection]; | |||
| SharingService *sharingService = [[SharingService alloc] initWithManagedObjectContext:[self managedObjectContext]]; | |||
| self.helper = [self authorizationHelper]; | |||
There was a problem hiding this comment.
Why assign self.helper here but then reassign it inside the attemptReconnect closure?
| } | ||
| } | ||
|
|
||
| - (SharingAuthorizationHelper *)authorizationHelper |
There was a problem hiding this comment.
Maybe refactor this to make helper a read-only lazy getter, and logic in this method part of the implementation?
There was a problem hiding this comment.
Alternatively, since this is the only place self.helper is really used (apart from the dealloc) maybe we could get rid of the property completely?
There was a problem hiding this comment.
The only reason we keep the property is so we can set the delegate to nil on dealloc.
There was a problem hiding this comment.
I wonder if this is necessary since the delegate is already a weak reference.
|
OK, here's another go at it, without the property. This felt like trying to write Swift optional style code in Obj-C, and it's so weird. Also, I'm so ready to move past success/failure async programming 😬 |
|
|
yo :)
We already show if a connection is broken from post options. This lets the user fix the issue right there. I had to refactor things a little bit as the sharing detail expected the publicize services to be synced, so I removed that requirement. It's still not bulletproof as the sync can fail and there's no retry, but I'd leave that for the new network infrastructure.
I also had to fix this crazy hard to debug thing where the same authorization web view would work from the Sharing section but not when presented from the editor, because the editor enables PrivateSiteURLProtocol. I updated it so it forwards redirects to the client, but perhaps we should limit it to wordpress.com sites (i.e. exclude public-api).
Fixes #6837
To test:
Needs review: @aerych