Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing WordPressAuthentication.framework #9198

Merged
merged 61 commits into from
May 1, 2018

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Apr 25, 2018

Details:

This PR implements WordPressAuthentication.framework:

  • Moves over all of the Authentication-Y classes.
  • Adds several missing imports.
  • Exposes few internal types that are being used by the main app.

Notes:

The following IB were relying on components that are now part of the Authentication framework (ie. NUXButton / SearchTableVIewCell.

We've patched them so that such components are now picked up from the right bundle (WordPressAuthenticator). I'm adding this for documentation purposes: not happy with the change, but works for now:

TextWithAccessoryButtonCell.xib
SignupEpilogueCell.xib
JetpackLoginViewController.xib
SignupEpilogue.storyboard
SiteCreation.storyboard
NoResults.storyboard

@nheagy @ScoutHarris @frosty @bummytime: Ladies and gentlemen, this PR is officially UP for review.

Since the Test Cases are HUGE i suggest we split them (maybe we can coordinate over Slack?).
We'll merge on three Squirrels :shipit:. Suggestions / observations are always more than welcome.

Thank you all!!!

cc @astralbodies @elibud @aerych


Scenario(s): WordPress.com Login

  • Log into a WordPress.com Account with Username + Password + 2FA Token (Manually Type it!)
  • Log into a WordPress.com Account with Username + Password + 2FA Token (Get the SMS!)
  • Log into a WordPress.com Account with Username + Password
  • Log into a WordPress.com Account with Magic Link
  • Log into a WordPress.com Account with Google!
  • Log into a WordPress.com Account with 1Password Integration
  • Log into a WordPress.com Account, by pressing enter your site address, and entering a WordPress.com URL + Username + Password

Please, for each scenario, verify that the Epilogue shows up correctly, and that your blogs are properly sync'ed.


Scenario: WordPress.org Login

  1. Fresh Install
  2. Log into a WordPress.org Site

Please verify that the Epilogue shows up correctly, and that your blog shows up in My Sites.


Scenario: Jetpack Login

  1. Log into a WordPress.org Site (that's connected to a dotcom account!)
  2. Press My Sites > Stats
  3. Log into the associated WordPress.com Account

Please, verify that the WordPress.com account is properly connected.


Scenario: WordPress.com Signup

  1. Signup for a new account using Email + Password
  2. Signup for a new account using Google

Scenario: Site Creation

  1. Log into an account that has no Sites
  2. Press the My Sites tab
  3. Press over Add New Site
  4. Press over Create WordPress.com site

Please: review the whole Site Creation flow!

@bummytime
Copy link
Member

Scenario: WordPress.org Login

  • Fresh Install
  • Log into a WordPress.org Site
  • Epilogue shows up correctly
  • blog shows up in My Sites

.org sites (no JP) seems to be working great @jleandroperez

@bummytime
Copy link
Member

bummytime commented Apr 27, 2018

Scenario(s): WordPress.com Login

  • Log into a WordPress.com Account with Username + Password + 2FA Token (Manually Type it!)
  • Log into a WordPress.com Account with Username + Password + 2FA Token (Get the SMS!)
  • Log into a WordPress.com Account with Username + Password
  • Log into a WordPress.com Account with Magic Link
  • Log into a WordPress.com Account with Google!
  • Log into a WordPress.com Account with 1Password Integration
  • Log into a WordPress.com Account, by pressing enter your site address, and entering a WordPress.com URL + Username + Password

Looking good on .com for me!

(Tested on both 10.3 and 11 devices)

@jleandroperez
Copy link
Contributor Author

@bummytime thanks SOOOO MUCH for your time!!!

@bummytime
Copy link
Member

Scenario: Jetpack Login

  • Log into a WordPress.org Site (that's connected to a dotcom account!); Press My Sites > Stats; Log into the associated WordPress.com Account

JP-connected .org works across devices

@bummytime
Copy link
Member

Scenario: WordPress.com Signup

  • Signup for a new account using Email + Password
  • Signup for a new account using Google

Signup tested well for me!

@bummytime
Copy link
Member

Scenario: Site Creation

  • Log into an account that has no Sites
  • Press the My Sites tab
  • Press over Add New Site
  • Press over Create WordPress.com site
  • Please: review the whole Site Creation flow!

I smoke tested this as well as I could and found no issues.

Copy link
Member

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty amazing work all around @jleandroperez! I smoke tested it pretty well on a variety of devices/iOS versions — I could not find a single issue.

As you mentioned in Slack, the code portion of this PR is pretty straight-forward and the unit tests are green ✅ .

I'll give you the 1st of 3 squirrels!

:shipit:

@jleandroperez
Copy link
Contributor Author

@bummytime BEST friday EVER ❤️ . Thank you!!!

@frosty
Copy link
Contributor

frosty commented Apr 30, 2018

Working my way through the list...

Scenario: WordPress.org Login:

  • Fresh Install
  • Log into a WordPress.org Site

Scenario: Jetpack Login:

  • Log into a WordPress.org Site (that's connected to a dotcom account!)
    Press My Sites > Stats
  • Log into the associated WordPress.com Account

Looking good!

@frosty
Copy link
Contributor

frosty commented Apr 30, 2018

Scenario: WordPress.com Signup:

  • Signup for a new account using Email + Password
  • Signup for a new account using Google

Scenario: Site Creation:

  • Log into an account that has no Sites
  • Press the My Sites tab
  • Press over Add New Site
  • Press over Create WordPress.com site

Copy link
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenario(s): WordPress.com Login:

  • Log into a WordPress.com Account with Username + Password + 2FA Token (Manually Type it!)
  • Log into a WordPress.com Account with Username + Password + 2FA Token (Get the SMS!)
  • Log into a WordPress.com Account with Username + Password
  • Log into a WordPress.com Account with Magic Link
  • Log into a WordPress.com Account with Google!
  • Log into a WordPress.com Account with 1Password Integration
  • Log into a WordPress.com Account, by pressing enter your site address, and entering a WordPress.com URL + Username + Password

Loooooooking goooooood! :shipit: 2 from me!

Amazing job pulling all this together!

Copy link
Contributor

@nheagy nheagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do this.

:shipit:

@jleandroperez
Copy link
Contributor Author

@frosty @bummytime @nheagy Thanks A LOT for your time + help!!!. Podfile.lock conflict solved. Merging whenever Buddybuild turns green!!

🔥

@jleandroperez jleandroperez merged commit b8aa4ec into develop May 1, 2018
@jleandroperez jleandroperez deleted the feature/wordpress-authenticator branch May 1, 2018 14:14
@astralbodies astralbodies mentioned this pull request May 25, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants