-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing WordPressAuthentication.framework #9198
Conversation
.org sites (no JP) seems to be working great @jleandroperez |
Looking good on .com for me! (Tested on both 10.3 and 11 devices) |
@bummytime thanks SOOOO MUCH for your time!!! |
JP-connected .org works across devices |
Signup tested well for me! |
I smoke tested this as well as I could and found no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty amazing work all around @jleandroperez! I smoke tested it pretty well on a variety of devices/iOS versions — I could not find a single issue.
As you mentioned in Slack, the code portion of this PR is pretty straight-forward and the unit tests are green ✅ .
I'll give you the 1st of 3 squirrels!
@bummytime BEST friday EVER ❤️ . Thank you!!! |
Working my way through the list... Scenario: WordPress.org Login:
Scenario: Jetpack Login:
Looking good! |
Scenario: WordPress.com Signup:
Scenario: Site Creation:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario(s): WordPress.com Login:
- Log into a WordPress.com Account with Username + Password + 2FA Token (Manually Type it!)
- Log into a WordPress.com Account with Username + Password + 2FA Token (Get the SMS!)
- Log into a WordPress.com Account with Username + Password
- Log into a WordPress.com Account with Magic Link
- Log into a WordPress.com Account with Google!
- Log into a WordPress.com Account with 1Password Integration
- Log into a WordPress.com Account, by pressing enter your site address, and entering a WordPress.com URL + Username + Password
Loooooooking goooooood! 2 from me!
Amazing job pulling all this together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's do this.
@frosty @bummytime @nheagy Thanks A LOT for your time + help!!!. 🔥 |
Details:
This PR implements WordPressAuthentication.framework:
Notes:
The following IB were relying on components that are now part of the Authentication framework (ie. NUXButton / SearchTableVIewCell.
We've patched them so that such components are now picked up from the right bundle (
WordPressAuthenticator
). I'm adding this for documentation purposes: not happy with the change, but works for now:@nheagy @ScoutHarris @frosty @bummytime: Ladies and gentlemen, this PR is officially UP for review.
Since the Test Cases are HUGE i suggest we split them (maybe we can coordinate over Slack?).
We'll merge on three Squirrels . Suggestions / observations are always more than welcome.
Thank you all!!!
cc @astralbodies @elibud @aerych
Scenario(s): WordPress.com Login
enter your site address
, and entering a WordPress.com URL + Username + PasswordPlease, for each scenario, verify that the Epilogue shows up correctly, and that your blogs are properly sync'ed.
Scenario: WordPress.org Login
Please verify that the Epilogue shows up correctly, and that your blog shows up in
My Sites
.Scenario: Jetpack Login
My Sites
>Stats
Please, verify that the WordPress.com account is properly connected.
Scenario: WordPress.com Signup
Scenario: Site Creation
My Sites
tabAdd New Site
Create WordPress.com site
Please: review the whole Site Creation flow!