Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignupUsernameViewController: Removes "Back" label from back nav button #9825

Merged
merged 1 commit into from Jul 20, 2018
Merged

SignupUsernameViewController: Removes "Back" label from back nav button #9825

merged 1 commit into from Jul 20, 2018

Conversation

bummytime
Copy link
Member

This PR removes the title label from the backBarButtonItem on the SignupUsernameViewController:

3

Fixes #9809

Testing

  1. Sign up for a new WP account using email or Google
  2. In the epilogue VC, tap the username field to change it
  3. On the SignupUsernameViewController screen, verify the back nav button has no title.

@nheagy would you mind taking a quick peek at this?

@bummytime bummytime added the NUX label Jul 20, 2018
@bummytime bummytime added this to the 10.6 milestone Jul 20, 2018
@bummytime bummytime self-assigned this Jul 20, 2018
@bummytime bummytime requested a review from nheagy July 20, 2018 17:42
@bummytime bummytime added this to In Progress in Groundskeeping Jul 20, 2018
@nheagy
Copy link
Contributor

nheagy commented Jul 20, 2018

This works :shipit:

@bummytime
Copy link
Member Author

Thanks @nheagy !

@bummytime bummytime merged commit 4727bfc into develop Jul 20, 2018
Groundskeeping automation moved this from In Progress to Done July 16 - 20, 2018 Jul 20, 2018
@bummytime bummytime deleted the fix/9809-username-screen-update branch July 20, 2018 20:31
@designsimply designsimply moved this from Done July 16 - 20, 2018 to Done Pre-July 16-20, 2018 in Groundskeeping Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nheagy nheagy nheagy approved these changes

Assignees

@bummytime bummytime

Labels
Login NUX
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bummytime @nheagy