-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove segue .showGoogle
#219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and programmatically navigate to the SignupGoogleVC
navigate to SignupGoogleVC
This was referenced Mar 24, 2020
Merged
Closed
ScoutHarris
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with wordpress-mobile/WordPress-iOS#13720.
Unified Login & Signup (iOS)
automation
moved this from In progress
to Reviewer approved
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
Ref. #182
This PR removes all references to the segue
.showGoogle
and programmatically navigates the user to theSignupGoogleViewController
. There are 3 areas where the segues have been removed:To Test - WPiOS
rake dependencies
and ensure there are no errorsTo Test - WCiOS
rake dependencies
.showGoogle
segue and navigate programmatically woocommerce/woocommerce-ios#2031