Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove segue .showGoogle #219

Merged
merged 13 commits into from
Mar 26, 2020
Merged

Remove segue .showGoogle #219

merged 13 commits into from
Mar 26, 2020

Conversation

mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Mar 24, 2020

Fixes #218
Ref. #182

This PR removes all references to the segue .showGoogle and programmatically navigates the user to the SignupGoogleViewController . There are 3 areas where the segues have been removed:

  1. WPiOS sign up
  2. WPiOS sign in
  3. WCiOS sign in

To Test - WPiOS

  1. Check out this branch
  2. rake dependencies and ensure there are no errors
  3. Build and run (there should be no errors)
  4. Visit the WPiOS PR to run the changes: Remove the .showGoogle segue and replace with programmatic nav  WordPress-iOS#13720

To Test - WCiOS

  1. Check out this branch
  2. rake dependencies
  3. Build and run (there should be no errors)
  4. Visit the WCiOS PR to run the changes: [Auth] Remove the .showGoogle segue and navigate programmatically woocommerce/woocommerce-ios#2031

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unified Login & Signup (iOS) automation moved this from In progress to Reviewer approved Mar 24, 2020
@mindgraffiti mindgraffiti merged commit 5867587 into develop Mar 26, 2020
Unified Login & Signup (iOS) automation moved this from Reviewer approved to Done Mar 26, 2020
@mindgraffiti mindgraffiti deleted the issue/218-remove-showGoogle branch March 26, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

UL&S: remove .showGoogle
2 participants