ULS: Update Help button color #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
12 tasks
Unified Login & Signup (iOS)
automation
moved this from In progress
to Reviewer approved
Jul 14, 2020
Gio2018
approved these changes
Jul 14, 2020
!| @@ -24,6 +24,9 @@ class SiteCredentialsViewController: LoginViewController { | |||
| override func viewDidLoad() { | |||
| super.viewDidLoad() | |||
|
|
|||
| navigationItem.title = WordPressAuthenticator.shared.displayStrings.logInTitle | |||
| styleNavigationBar(forUnified: true) | |||
|
|
|||
| localizePrimaryButton() | |||
There was a problem hiding this comment.
is it just my browser or GitHub is messing up with the indentation? When I open it in Xcode, everything is in order anyway.
There was a problem hiding this comment.
I noticed that too when Thuy first added this file. It appeared all kinds of wrong on the PR, but in code it's fine. 🤷 .
|
Thanks @Gio2018 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #315
This adds functionality to set the
Helpnav button text color based on the nav bar being displayed. It also enables the unified nav bar on the Site Credentials view.For the unified flows, it is now the same blue as the
Backbutton.For the original flows, it is still white.
To note, when tapping
Helpand theSupportview is displayed, theClosebutton (left bar button) color is incorrect for the unified flow. Stay tuned!Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#14457