Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login / signup buttons copy and font #572

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

yaelirub
Copy link
Contributor

@yaelirub yaelirub commented Feb 2, 2021

WPiOS issue: wordpress-mobile/WordPress-iOS#15703
This PR updates the copy on the login / signup button from "Welcome to WordPress.com" to "Log in or sign up with WordPress.com"

Since the title is more lengthy, this PR also updates the title label font of both buttons from title3 to body per design

Simulator Screen Shot - iPhone 12 Pro - 2021-02-01 at 19 44 51

To Test:

  1. Update the WordPressAuthenticator path in WPiOS to this branch
  2. Be signed out
  3. See copy as described
  4. See font is body as described
  5. Continue to next screen and see button title fonts are unchanged (title3)

@yaelirub yaelirub added the enhancement New feature or request label Feb 2, 2021
Copy link
Member

@mattmiklic mattmiklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine in English at the default font size, so I'm going ahead with my 👍 here -- but it would be good to get a build so we can look at longer translations, and non-default system font sizes, to make sure the buttons adapt gracefully.

@mattmiklic
Copy link
Member

I tested the build with dynamic font sizes enabled and in some other languages. I think we are generally fine to launch this as-is. I do have one suggestion for improvement but as it's not a regression, it can be a separate issue.

At the current font sizes, some of the buttons are split into two lines. German is a good example. The same is true when dynamic font sizes are enabled. When the text wraps to two lines, we'd benefit from having some top and bottom padding in the button element to keep the text from getting uncomfortably close to the edge of the button shape.

@ScoutHarris
Copy link
Contributor

FWIW, there is an open issue to redo that button because of wrapping issues. #501.

@yaelirub yaelirub merged commit 67228a1 into develop Feb 3, 2021
@yaelirub yaelirub deleted the task/update_login_button_title_and_font branch February 3, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants