Adds optional bottom switch to FancyAlertView #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
approved these changes
Nov 1, 2018
Example/Example/ViewController.swift
Outdated
| } | ||
|
|
||
| // MARK: Fancy Alert | ||
|
|
||
| func showFancyAlert() { | ||
| func showFancyAlert( | ||
| moreInfoButton: FancyAlertViewController.Config.ButtonConfig? = nil, |
There was a problem hiding this comment.
Is this extra space on purpose? Not sure if this is a new guideline, but it's a bit confusing!!
Example/Example/ViewController.swift
Outdated
| } | ||
|
|
||
| func showFancyAlertWithSwitch() { | ||
|
|
There was a problem hiding this comment.
Nipticky: Extra newline here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an optional bottom switch to
FancyAlertView. This is intended to be used (at least initially) as a "Do not show this again" option for the alert.Also adds 2 demos to showcase the "More information" button and the newly added switch.
Also fixes all unit tests.
Testing:
Make sure the code looks fine.
Make sure the unit tests run fine.
Run the example App and: