Skip to content

Commit

Permalink
Remove settings from build.sh already set in xcconfig
Browse files Browse the repository at this point in the history
This is but another attempt of getting a version built with Xcode 14.3
to work on Xcode 14.3.1
  • Loading branch information
mokagio committed Jul 3, 2023
1 parent 38950b6 commit 135dcb1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
10 changes: 2 additions & 8 deletions ios-xcframework/Config/Gutenberg-Shared.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,8 @@ SWIFT_VERSION = 5.0
TARGETED_DEVICE_FAMILY = 1,2
VERSION_INFO_PREFIX =
VERSIONING_SYSTEM = apple-generic
// These should be unnecessary because the script that builds the project should set it.
//
// But I'm getting the following error after switching from Xcode 14.3 to 14.3.1:
//
// > Failed to build module 'Gutenberg'; this SDK is not supported by the compiler
// > (the SDK is built with 'Apple Swift version 5.8 (swiftlang-5.8.0.124.2 clang-1403.0.22.11.100)',
// > while this compiler is 'Apple Swift version 5.8.1 (swiftlang-5.8.0.124.5 clang-1403.0.22.11.100)').
// > Please select a toolchain which matches the SDK.
// These two settings are to ensure the framework can be used by projects using
// a different compiler version than the one used to build it.
//
// See also https://github.com/facebook/facebook-ios-sdk/issues/2180#issuecomment-1485846511
BUILD_LIBRARY_FOR_DISTRIBUTION = YES
Expand Down
4 changes: 1 addition & 3 deletions ios-xcframework/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,7 @@ function archive {
-configuration Release \
-sdk "$PLATFORM" \
-archivePath "$ARCHIVES_ROOT/$PLATFORM.xcarchive" \
-derivedDataPath "$DERIVED_DATA_PATH" \
BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
SKIP_INSTALL=NO
-derivedDataPath "$DERIVED_DATA_PATH"
}

BUILD_DIR=./build
Expand Down

0 comments on commit 135dcb1

Please sign in to comment.