Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block created on mobile shows invalid content message on web #1237

Closed
JavonDavis opened this issue Jul 19, 2019 · 7 comments
Closed

Video Block created on mobile shows invalid content message on web #1237

JavonDavis opened this issue Jul 19, 2019 · 7 comments
Labels
Jetpack Bug or feature related to Jetpack [Type] Bug Something isn't working

Comments

@JavonDavis
Copy link
Contributor

Steps to reproduce:

  1. Create a new post or open an existing post
  2. Add at least one video block, take a new video
  3. Save the draft
  4. Open the same post on the web

Mobile

IMG_E21BB00604B1-1

Web:

Screen Shot 2019-07-19 at 10 22 01 AM

@hypest hypest added the [Type] Bug Something isn't working label Jul 19, 2019
@hypest hypest added the HACK 7/2019 HACK week July 2019 label Jul 23, 2019
@maxme
Copy link
Contributor

maxme commented Jul 23, 2019

I did a quick test and found that the local path was used in the block:

<!-- wp:video {"id":2} -->
<figure class="wp-block-video">
  <video src="///data/user/0/org.wordpress.android.beta/cache/VID_20190722_113956.mp4" controls="controls" width="300" height="150"></video>
</figure>
<!-- /wp:video -->

I tried the same experiment with Aztec and the correct (remote) url was set in the video shortcode.

@maxme maxme self-assigned this Jul 23, 2019
@maxme
Copy link
Contributor

maxme commented Jul 23, 2019

I wonder if this is linked to this one wordpress-mobile/WordPress-Android#10203

I was able to upload a post with a video correctly once in Gutenberg. IMO this one needs some more investigation on the wpandroid side first.

@mchowning
Copy link
Contributor

This may also be related to #1152

@maxme maxme removed their assignment Aug 5, 2019
@hypest hypest removed the HACK 7/2019 HACK week July 2019 label Sep 3, 2019
@mchowning
Copy link
Contributor

I've seen this issue before, but in testing this now I think the issue has been resolved. Tested both Android and iOS. If someone else can double-check that the issue is fixed, I think we can close this.

On a related note, I still see #1152 (video added on web shows invalid block on mobile) occurring.

@Tug
Copy link
Contributor

Tug commented Nov 20, 2019

Can confirm, (tested on WPAndroid only)

@Tug
Copy link
Contributor

Tug commented Nov 20, 2019

Actually I can reproduce from a Jetpack site.
Also, it looks like the issue can be resolved from the block editor "Resolve" function. It seems to be missing an empty value for controls (="") in the video element:

image

@Tug Tug reopened this Nov 20, 2019
@Tug Tug added the Jetpack Bug or feature related to Jetpack label Nov 20, 2019
@SiobhyB
Copy link
Contributor

SiobhyB commented Nov 16, 2023

I tested on a Jetpack-connected site and am no longer able to reproduce this issue. Video blocks added via my phone displayed as expected on the web. It looks like there must have been a change to the way a value is assigned to the controls argument.

<!-- wp:video {"id":11} -->
<figure class="wp-block-video"><video controls src="https://example.testing.com/wp-content/uploads/2023/11/testing.mp4"></video></figure>
<!-- /wp:video -->

@SiobhyB SiobhyB closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Bug or feature related to Jetpack [Type] Bug Something isn't working
Projects
Status: Done (keep clean, manually)
Development

No branches or pull requests

6 participants