Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings from Jetpack are not included in the bundle #2615

Closed
mchowning opened this issue Sep 14, 2020 · 2 comments · Fixed by #4359
Closed

Strings from Jetpack are not included in the bundle #2615

mchowning opened this issue Sep 14, 2020 · 2 comments · Fixed by #4359
Assignees
Labels
[Pri] High [Type] Bug Something isn't working

Comments

@mchowning
Copy link
Contributor

Describe the bug
When we run our bundle script we are not including strings from jetpack in the resulting bundle.

To Reproduce
Steps to reproduce the behavior:

  1. npm run genstrings
  2. Observe that the strings files (i.e., bundle/android/strings.xml) do not contain relevant strings from the jetpack repo: for example, "Link address to Google Maps").

Expected behavior
Relevant strings from the jetpack repos should be included in our bundles for translation.

@mchowning mchowning added [Type] Bug Something isn't working [Pri] High labels Sep 14, 2020
@mchowning mchowning self-assigned this Sep 14, 2020
@mchowning mchowning changed the title Strings from jetpack are not being translated Strings from Jetpack are not included in the bundle Sep 14, 2020
@hypest hypest added this to Triage in Mobile Gutenberg via automation Sep 18, 2020
@hypest hypest moved this from Triage to In progress in Mobile Gutenberg Sep 18, 2020
@mchowning
Copy link
Contributor Author

This may actually be a duplicate of #2162.

@fluiddot fluiddot self-assigned this Dec 1, 2021
Mobile Gutenberg automation moved this from In progress to Done (keep clean, manually) Dec 27, 2021
@mkevins mkevins mentioned this issue Jan 7, 2022
4 tasks
@fluiddot
Copy link
Contributor

fluiddot commented Jan 13, 2022

2. Observe that the strings files (i.e., bundle/android/strings.xml) do not contain relevant strings from the jetpack repo: for example, "Link address to Google Maps").

The string Link address to Google Maps is included in the Jetpack's GlotPress project (reference), so it's not expected that this string will be part of the localization strings files (i.e. bundle/android/strings.xml), as these files only contain the strings that are exclusively referenced in JS native files (i.e. *.native.js).

As an alternative example, the string Address Settings (code reference) is one that is only referenced in a JS native file, and besides is already included in the localization strings files (reference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment