Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations broken in the block picker #3269

Closed
guarani opened this issue Mar 16, 2021 · 4 comments
Closed

Translations broken in the block picker #3269

guarani opened this issue Mar 16, 2021 · 4 comments
Assignees
Labels

Comments

@guarani
Copy link
Contributor

guarani commented Mar 16, 2021

Describe the bug

This is a bug affecting the current 1.48.1 release (WPiOS 16.9), not 1.47.x (WPiOS 16.8).

The block inserter isn't displaying block names in the device language (e.g. German).

To Reproduce
Steps to reproduce the behavior:

  1. Download the 16.9 beta from TestFlight
  2. Switch your device over to German (or any other supported non-English language)
  3. Open the block editor
  4. Open the block inserter and notice that block names appear in English instead of German
  5. Other parts of the editor may also have missing translations

Expected behavior
On a device with a language set to German, block names should appear in German, as they did in 16.8.

Screenshots
German translation not showing up

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 14.4
  • Version 16.9 beta

Additional context
This does not affect Android, I tested WPAndroid 16.9 beta and the translations look fine there.

@guarani guarani added [Type] Bug Something isn't working [OS] iOS i18n labels Mar 16, 2021
@guarani guarani self-assigned this Mar 16, 2021
@hypest hypest added this to Triage in Mobile Gutenberg via automation Mar 17, 2021
@hypest hypest moved this from Triage to In progress in Mobile Gutenberg Mar 17, 2021
@hypest
Copy link
Contributor

hypest commented Mar 17, 2021

Added the "Pri High" label as this is about a core feature: i18n.

@mchowning
Copy link
Contributor

@mchowning
Copy link
Contributor

Do you think we can close this issue @fluiddot ?

@fluiddot
Copy link
Contributor

Do you think we can close this issue @fluiddot ?

Yeah, this issue has been fixed via #3423.

Mobile Gutenberg automation moved this from In progress to Done (keep clean, manually) Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Mobile Gutenberg
  
Done (keep clean, manually)
Development

No branches or pull requests

4 participants