Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter - show Picker with registered blocks to choose from #105

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 13, 2018

This completes a very draft, initial 1st iteration on implementing the inserter flow. With this, the flow goes roughly along the lines of the expected actions like this:

  1. focusing on an item shows an item toolbar which for now currently includes the + button to insert a new item (this + trigger will be moved to the toolbar as per the designs Inserter #58 (comment))
  2. tapping on + makes a RN Picker show up
  3. tap on the picker to choose the type of block you'd like to insert
  4. a newly created block is inserted right below the block that was being focused on.

inserter-picker

Known issues:

For this I'm working on another implementation with a modal dialog and a flatlist, but wanted to continue to put this PR up and complete a first "working" flow at least.

@mzorz mzorz changed the title Inserter: show Picker with registered blocks to choose from Inserter - show Picker with registered blocks to choose from Aug 13, 2018
@mzorz mzorz mentioned this pull request Aug 13, 2018
4 tasks
@koke
Copy link
Member

koke commented Aug 14, 2018

The UX makes sense on Android but it's quite odd on iOS: it's showing a picker and inserting the block when the value changes.

inserter-ios

This is unusual on iOS where you'd require an extra step to validate the selection. The equivalent to the android UI would be a UIAlertController with the actionSheet style.

This might be good enough for a temporary design but I wanted to note it's a very odd experience on iOS.

Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm editing a text block and I add another, the "focus" switches to the newly inserted block, but the cursor stays in the previous block. I'm not sure if we're worrying about that at this point, but leaving a note here.

Otherwise, this is looking good :shipit:

@mzorz
Copy link
Contributor Author

mzorz commented Aug 14, 2018

Tracked issue in #113 - closing this PR in favor of #112

@mzorz mzorz closed this Aug 14, 2018
@mzorz mzorz deleted the try/inserter-take1-state-props-show-reg-blocks branch October 25, 2018 20:34
Tug added a commit that referenced this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants