Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textAlignVertical to html text input. #114

Merged
merged 2 commits into from Aug 15, 2018

Conversation

etoledom
Copy link
Contributor

This is a first small step on improving the html text input UX.

This PR fixes the input view on Android when it is empty. Now the cursor goes to the top instead of the middle of the screen.

cursor

To test:

  • Run the project on Android.
  • Switch to HTML view.
  • Remove all the text.
  • Check that the cursor is at the top.

This fixes text input cursor position on Android when the text input is empty.
@etoledom etoledom self-assigned this Aug 14, 2018
@etoledom etoledom requested a review from mzorz August 14, 2018 16:03
@etoledom etoledom mentioned this pull request Aug 14, 2018
2 tasks
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etoledom etoledom mentioned this pull request Aug 15, 2018
5 tasks
@etoledom etoledom changed the base branch from feature/parse-html-into-blocks to master August 15, 2018 18:22
@etoledom etoledom merged commit 33d9f6c into master Aug 15, 2018
@etoledom etoledom deleted the feature/html-input-view-ux branch August 15, 2018 18:23
daniloercoli added a commit that referenced this pull request Jan 29, 2019
…ont-family-weight-style-from-RN

[Android] Add the ability to set font family, weight, size, and style from RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants