Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract caption component #1254

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@mchowning
Copy link
Contributor

commented Jul 30, 2019

This PR extract caption from image block to be shared with video block. This ports over both rich text styling and a keyboard-dismissal bug fix to the video block. It also adds the ability to select the video block when the video block's caption is selected without playing the video.

Further details and testing instructions are in the related gutenberg PR.

There are user facing changes, so I have added an item to RELEASE-NOTES.txt.

@mchowning

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

Labeling this as not ready for review while I dig into the test failures

@mchowning mchowning force-pushed the extract_caption_component branch from 0dbdbbb to d13977b Jul 31, 2019
@mchowning mchowning requested a review from Tug Jul 31, 2019
@mchowning mchowning added this to the 1.11 milestone Jul 31, 2019
@etoledom

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Hey @mchowning !
I try to update the submodule but I get an error:

❯❯❯ git submodule update
error: Server does not allow request for unadvertised object 7f487d33f6e498a88e7230dba390638b4b93e570
Fetched in submodule path 'gutenberg', but it did not contain 7f487d33f6e498a88e7230dba390638b4b93e570. Direct fetching of that commit failed.

Maybe you haven't push the last commit to the gutenberg repo?

@mchowning mchowning force-pushed the extract_caption_component branch from d13977b to 8b2363a Aug 2, 2019
@mchowning

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

I try to update the submodule but I get an error... Maybe you haven't push the last commit to the gutenberg repo?

👋 @etoledom ! So sorry about that. Actually, It was this repo that I forgot to update 🙁 and because I force-pushed over 7f487d3 in gutenberg, that commit got gc'd (explains why the gutenberg-mobile build was able to pull 7f487d3 2 days ago but it's gone now).

@mchowning mchowning force-pushed the extract_caption_component branch from 8b2363a to e1308eb Aug 8, 2019
Copy link
Contributor

left a comment

Great job!
Tested via WordPress/gutenberg#16825 (review)

@mchowning mchowning force-pushed the extract_caption_component branch 3 times, most recently from b1bd0cc to 9f0b48b Aug 8, 2019
@mchowning mchowning force-pushed the extract_caption_component branch from 9f0b48b to 19c52ab Aug 20, 2019
@mchowning mchowning merged commit d8aeb9b into develop Aug 20, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@mchowning mchowning deleted the extract_caption_component branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.