Image block vol 03 (sizing) #147
Conversation
|
@hypest - Could you please take a look at this? Thank you! I'll check the merge conflict first time tomorrow. My first test didn't work well. (Updating the |
|
Sent an update and finally everything seems to be green in both projects! 🎉 I believe this is ready for a review. |
| @@ -35,10 +35,6 @@ registerBlockType( UnsupportedBlock.name, UnsupportedBlock.settings ); | |||
| setUnknownTypeHandlerName( UnsupportedBlock.name ); | |||
|
|
|||
| const initialHtml = ` | |||
| <!-- wp:image --> | |||
There was a problem hiding this comment.
I wonder if there is some background info here on why we remove the "upload placeholder" case. Can you elaborate @etoledom ? Thanks!
There was a problem hiding this comment.
For organization.
I added both together before for testing purposes, but I had in mind to leave just one from the beginning. Now we can add the empty one by adding a new Image Block.
There's no problem to add the empty one back if we want to have everything visible anyway! 👍
There was a problem hiding this comment.
Ah, I see. No, that's cool, no need to reinstate it. It was just not clear because the actual code changes are on the GB repo side and I wasn't sure if we lost that feature or not. Thanks!
|
This PR has become irrelevant. We can push a new one when we retake the Images sizing work. |
Part of #140
This PR implement the changes related to Image Block sizing on the Gutenberg project.
Please follow the instruction on the mentioned PR for testing.