Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image block Caption. #161

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Image block Caption. #161

merged 4 commits into from
Oct 17, 2018

Conversation

etoledom
Copy link
Contributor

Part of #140

This PR implements the changes on the main gutenberg repo to show the image caption on the image block.

caption

To test:

  • Checkout and update Gutenberg.
  • Run the project.
  • Check that the caption is visible.
  • Check that you can edit and remove the caption.
  • Check that the changes are visible on the HTML view.

@etoledom etoledom self-assigned this Oct 15, 2018
@etoledom etoledom requested a review from hypest October 15, 2018 13:33
@etoledom etoledom mentioned this pull request Oct 15, 2018
Closed
@etoledom etoledom merged commit fbdd8af into master Oct 17, 2018
@etoledom etoledom deleted the feature/image-caption branch October 17, 2018 11:55
@etoledom etoledom mentioned this pull request Oct 17, 2018
Closed
10 tasks
@koke koke mentioned this pull request Oct 17, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest Awaiting requested review from hypest

Assignees

@etoledom etoledom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@etoledom