Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update houndci to support es6 #3326

Closed
wants to merge 7 commits into from
Closed

Update houndci to support es6 #3326

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d903865
Update houndci to support es6
enejb Mar 31, 2021
dc69728
Update file to be in json format
enejb Mar 31, 2021
ab05abd
Reorder imports
enejb Mar 31, 2021
1e19909
Fixes to the json document.
enejb Mar 31, 2021
39c1c07
Lets see if this will make hound fail
enejb Mar 31, 2021
908f177
Add eslint ignore to hound
enejb Mar 31, 2021
a0d2c4b
Add swiftlint config to hound
enejb Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 0 additions & 30 deletions .eslintrc.js
View file
Open in desktop

This file was deleted.

43 changes: 43 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"parser": "babel-eslint",
"env": {
"node": true,
"browser": true,
"es6": true,
"jest/globals": true
},
"globals": {
"__DEV__": true
},
"plugins": [
"react",
"react-native",
"jest"
],
"extends": [
"plugin:@wordpress/eslint-plugin/recommended"
],
"settings": {
"import/resolver": {
"node": {
"moduleDirectory": [
"node_modules",
"gutenberg/node_modules"
]
}
}
},
"rules": {
// do not throw an error if imported dependencies are
// declared in `package.json` or `gutenberg/package.json`
"import/no-extraneous-dependencies": [
"error",
{
"packageDir" : [
".",
"./gutenberg/"
]
}
]
}
}
4 changes: 4 additions & 0 deletions .hound.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
javascript:
enabled: false
eslint:
enabled: true
Comment on lines +3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Hound documentation would imply we need to add a pointer to our own eslint configuration file. Did you find Hound worked without explicitly adding the path?

Suggested change
eslint:
enabled: true
eslint:
enabled: true
config_file: .eslintrc.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I am able to confirm either way.

2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {
* Internal dependencies
*/
import correctTextFontWeight from './text-font-weight-correct';
import setupJetpackEditor from './jetpack-editor-setup';
import initialHtml from './initial-html';
import setupJetpackEditor from './jetpack-editor-setup';

addAction( 'native.pre-render', 'gutenberg-mobile', () => {
require( './strings-overrides' );
Expand Down