Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies from forks to use release tags #3651

Merged
merged 24 commits into from
Jul 20, 2021
Merged

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Jun 22, 2021

Gutenberg PR: WordPress/gutenberg#32893
Gutenberg Mobile PR: #3651
WPiOS PR: wordpress-mobile/WordPress-iOS#16724
WPAndroid PR: wordpress-mobile/WordPress-Android#14894

Fixes: #3539

To test: See Gutenberg PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 22, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun assigned dcalhoun and unassigned dcalhoun Jul 13, 2021
@ceyhun ceyhun requested a review from dcalhoun July 13, 2021 13:21
@ceyhun ceyhun marked this pull request as ready for review July 13, 2021 13:21
@ceyhun ceyhun removed the request for review from dcalhoun July 15, 2021 15:41
@ceyhun ceyhun requested a review from fluiddot July 15, 2021 15:41
bin/generate-podspecs.sh Show resolved Hide resolved
@@ -6253,6 +6259,7 @@
"babel-eslint": "^10.1.0",
"cosmiconfig": "^7.0.0",
"eslint-config-prettier": "^7.1.0",
"eslint-plugin-import": "^2.23.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most of the changes on this file are coming from bumping the version of eslint-plugin-import package in this commit so looks safe to merge them 👍 .

third-party-podspecs/RNSVG.podspec.json Show resolved Hide resolved
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#32893 (review).

NOTE: The Gutenberg ref should be updated to the merge commit of the related Gutenberg PR before merging.

@ceyhun ceyhun merged commit 6924222 into develop Jul 20, 2021
@ceyhun ceyhun deleted the update-fork-refs branch July 20, 2021 11:28
@fluiddot fluiddot mentioned this pull request Jul 22, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react-native forked libs react-native-mirror from bintray to S3
3 participants