Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider and stepper text inputs in dark mode #3724

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Fix slider and stepper text inputs in dark mode #3724

merged 4 commits into from
Jul 16, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jul 13, 2021

Fixes WordPress/gutenberg#33406

To test:
See WordPress/gutenberg#33402

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani requested a review from ceyhun July 13, 2021 23:01
@guarani guarani mentioned this pull request Jul 13, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 15, 2021 •
edited

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

ceyhun
ceyhun approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#33402

@ceyhun
Copy link
Contributor

ceyhun commented Jul 16, 2021

Hey there @guarani 👋 I merged the Gutenberg PR to cherry pick for 1.57.1 betafix, but this one seems to have a conflict for gutenberg ref.

@guarani
Copy link
Contributor Author

guarani commented Jul 16, 2021

Hey there @guarani 👋 I merged the Gutenberg PR to cherry pick for 1.57.1 betafix, but this one seems to have a conflict for gutenberg ref.

Thanks for flagging, I've updated with the latest from develop and will merge after the checks pass.

@guarani guarani enabled auto-merge July 16, 2021 18:49
@guarani guarani merged commit e9939dd into develop Jul 16, 2021
@guarani guarani deleted the fix/range-text-input-dark branch July 16, 2021 19:08
@fluiddot fluiddot mentioned this pull request Jul 22, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RNMobile: Slider and stepper text inputs not rendering correct color in dark mode
2 participants
@guarani @ceyhun