Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.116.0 #6773

Merged
merged 7 commits into from Mar 27, 2024
Merged

Release 1.116.0 #6773

merged 7 commits into from Mar 27, 2024

Conversation

geriux
Copy link
Member

@geriux geriux commented Mar 27, 2024 •
edited

Release for Gutenberg Mobile 1.116.0

Related PRs

Changes

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

geriux
geriux commented Mar 27, 2024
View reviewed changes
bundle/android/strings.xml
@@ -91,6 +91,7 @@
<string name="gutenberg_native_choose_images" tools:ignore="UnusedResources">Choose images</string>
<string name="gutenberg_native_choose_video" tools:ignore="UnusedResources">Choose video</string>
<string name="gutenberg_native_clear_search" tools:ignore="UnusedResources">Clear search</string>
<string name="gutenberg_native_clear_selected_color" tools:ignore="UnusedResources">Clear selected color</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new entry was added in with this recent change.

This was referenced Mar 27, 2024
Merged
Merged
@geriux geriux requested a review from twstokes March 27, 2024 15:31
twstokes
twstokes approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @geriux! 🚀

@geriux geriux enabled auto-merge March 27, 2024 19:31
@geriux geriux merged commit be7aec2 into trunk Mar 27, 2024
20 of 23 checks passed
@geriux geriux deleted the release/1.116.0 branch March 27, 2024 19:55
@geriux
Copy link
Member Author

geriux commented Apr 3, 2024 •
edited

🟢 Basic Test Suite Checklist

Build: 24.6-rc-1
Device: Samsung Galaxy A23 5G (Android 14)

Writing Flow

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Unsupported Block

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Gallery Block

  • TC005 - Choose from device (stay in editor) - Successful upload

@geriux
Copy link
Member Author

geriux commented Apr 3, 2024 •
edited

🟢 New changes (Android)

Build: 24.6-rc-1
Device: Samsung Galaxy A23 5G (Android 14)

@geriux
Copy link
Member Author

geriux commented Apr 3, 2024 •
edited

🟢 Functionality tests - Test Suite 1 (Android)

Build: 24.6-rc-1
Device: Samsung Galaxy A23 5G (Android 14)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

@twstokes
Copy link
Contributor

twstokes commented Apr 4, 2024 •
edited

🟢 Basic Test Suite Checklist (iOS)

Build: TestFlight 24.6.0.1
Device: iPhone 12 (iOS 17.4.1)

Writing Flow

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Unsupported Block

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Gallery Block

  • TC005 - Choose from device (stay in editor) - Successful upload

@twstokes
Copy link
Contributor

twstokes commented Apr 5, 2024 •
edited

🟢 New changes (iOS)

Build: TestFlight 24.6.0.1
Device: iPhone 12 (iOS 17.4.1)

@twstokes
Copy link
Contributor

twstokes commented Apr 5, 2024 •
edited

🟢 Test Suite 2 (iOS)

Build: TestFlight 24.6.0.1
Device: iPhone 12 (iOS 17.4.1)

Group - 1

  • Group - Deep nesting is possible (verify iOS does not crash) - TC001
  • Group - Check if Group placeholder is visible for the unselected state - TC002
  • Group - Check if Group placeholder is render in nested structure - TC003
  • Group - Nested block have proper border styling - TC004
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC005

Buttons-1

  • Buttons block - Button's wrapper grows properly - TC019
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC002
  • Buttons block - Wrapping Buttons - TC003

Button-2

  • Buttons block - Buttons alignment options - TC004
  • Buttons block - Settings: Open in new tab - TC007
  • Buttons block - Settings: Link rel - TC008

Button-3

  • Buttons block - Settings: Link URL - TC006
  • Buttons block - Settings: Remove link - TC010
  • Buttons block - Settings: Synchronize with button options - TC009

Color Settings - 1

  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Drag and Drop Blocks - 1

  • Drag and Drop Blocks - Drag block to the top of the content - TC001
  • Drag and Drop Blocks - Drag block to the bottom of the content - TC002

VideoPress - 2

  • VideoPress block - Player - TC003
  • VideoPress block - Private video - TC005
  • VideoPress block - Upload limit for Free users - TC006

@twstokes
Copy link
Contributor

twstokes commented Apr 5, 2024

One issue I noticed on my simple site (https://twstokes.wordpress.com) was that no gradients were showing up for a button background color.

Build: TestFlight 24.6.0.1
Device: iPhone 12 (iOS 17.4.1)

button_gradient.MP4

@geriux
Copy link
Member Author

geriux commented Apr 8, 2024

was that no gradients were showing up for a button background color.

Interesting, which theme were you using for that test?

@twstokes
Copy link
Contributor

twstokes commented Apr 8, 2024

was that no gradients were showing up for a button background color.

Interesting, which theme were you using for that test?

Looks like "Spiel". Feel free to add yourself to the test blog if needed - twstokes.wordpress.com.

@geriux
Copy link
Member Author

geriux commented Apr 10, 2024

I've created a GitHub ticket WordPress/gutenberg#60629 to track this issue since it's not a regression of this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geriux @twstokes