Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular dependencies within the components package #6874

Merged
merged 3 commits into from
May 20, 2024
Merged

Remove circular dependencies within the components package #6874

merged 3 commits into from
May 20, 2024

Conversation

geriux
Copy link
Member

@geriux geriux commented May 17, 2024

Related PRs:

Addresses WordPress/gutenberg#52692

To test all CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added this to the 1.119.0 (24.9) milestone May 17, 2024
@geriux geriux requested a review from twstokes May 17, 2024 09:22
@geriux geriux marked this pull request as ready for review May 17, 2024 09:22
twstokes
twstokes approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geriux!

@geriux geriux merged commit 9beccb8 into trunk May 20, 2024
20 checks passed
@geriux geriux deleted the fix/mobile-circular-dependencies branch May 20, 2024 07:19
@twstokes twstokes mentioned this pull request May 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees
No one assigned
Labels
[Type] Technical Debt
Projects
None yet
Milestone
1.119.0 (25.0)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geriux @twstokes