This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Diff between wp-fork branch and main repo's default branch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves errors during `npm install`'s `prepare` phase. Because of the lack of a `package-lock.json`
file, npm installed the latest versions of all the `@react-navigation/*`
packages and their type definitions were not matching.
The errors were:
```
ℹ Generating type definitions with tsc
src/native-stack/navigators/createNativeStackNavigator.tsx:32:5 - error TS2314: Generic type 'StackNavigationState' requires 1 type argument(s).
32 StackNavigationState,
~~~~~~~~~~~~~~~~~~~~
src/native-stack/navigators/createNativeStackNavigator.tsx:32:5 - error TS2558: Expected 5 type arguments, but got 4.
32 StackNavigationState,
~~~~~~~~~~~~~~~~~~~~~
33 StackRouterOptions,
~~~~~~~~~~~~~~~~~~~~~~~
34 NativeStackNavigationOptions,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
35 NativeStackNavigationEventMap
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/native-stack/navigators/createNativeStackNavigator.tsx:73:7 - error TS2322: Type 'Record<string, Descriptor<Record<string, object | undefined>, string, any, NativeStackNavigationEventMap, {}>>' is not assignable to type 'NativeStackDescriptorMap'.
Index signatures are incompatible.
Type 'Descriptor<Record<string, object | undefined>, string, any, NativeStackNavigationEventMap, {}>' is not assignable to type 'Descriptor<Record<string, object | undefined>, string, any, NativeStackNavigationOptions, {}>'.
Types of property 'options' are incompatible.
Type 'NativeStackNavigationEventMap' has no properties in common with type 'NativeStackNavigationOptions'.
73 descriptors={descriptors}
~~~~~~~~~~~
src/native-stack/views/NativeStackView.tsx:24:3
24 descriptors: NativeStackDescriptorMap;
~~~~~~~~~~~
The expected type comes from property 'descriptors' which is declared here on type 'IntrinsicAttributes & Props'
src/native-stack/navigators/createNativeStackNavigator.tsx:79:3 - error TS2314: Generic type 'StackNavigationState' requires 1 type argument(s).
79 StackNavigationState,
~~~~~~~~~~~~~~~~~~~~
src/native-stack/types.tsx:31:3 - error TS2314: Generic type 'StackNavigationState' requires 1 type argument(s).
31 StackNavigationState,
~~~~~~~~~~~~~~~~~~~~
src/native-stack/types.tsx:254:3 - error TS2314: Generic type 'StackNavigationState' requires 1 type argument(s).
254 StackNavigationState,
~~~~~~~~~~~~~~~~~~~~
src/native-stack/views/NativeStackView.tsx:22:10 - error TS2314: Generic type 'StackNavigationState' requires 1 type argument(s).
22 state: StackNavigationState;
~~~~~~~~~~~~~~~~~~~~
src/native-stack/views/NativeStackView.tsx:36:26 - error TS7006: Parameter 'route' implicitly has an 'any' type.
36 {state.routes.map((route) => {
~~~~~
Found 8 errors.
✖ Failed to build definition files.
```
Upgrade to gradle 7.1.1
Add tarball
Routine RN package upgrade.
…tive-0.66 Update to RN 0.66.2
|
Closing this PR as we no longer need the fork 👋 (more info in #8). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.