Release 1.4.0 into develop #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note here on the failing GitHub Actions build because: I need to learn more about how Bundler 2.2.x manages the platforms, but I think we can work around this by adding the following to (We could also ignore this and move on, but isn't it unsatisfying?) |
mokagio
added a commit
that referenced
this pull request
Aug 4, 2021
See discussion here: #292 (comment) To ensure the setting is persisted for every user of the repository, I decided to track the Bundler config file. This seems like a good idea anyway, even though Bundler currently has a bug resulting in that file being changed sometimes, which can be confusing for developers. See rubygems/rubygems#3708
See discussion here: #292 (comment) To ensure the setting is persisted for every user of the repository, I decided to track the Bundler config file. This seems like a good idea anyway, even though Bundler currently has a bug resulting in that file being changed sometimes, which can be confusing for developers. See rubygems/rubygems#3708
We don't need them because we don't run the tests in that workflow.
There is no "screenshots" group. That option didn't produce any effect.
|
Opened #293 to address the CI issue. |
Codecov Report
@@ Coverage Diff @@
## develop #292 +/- ##
===========================================
+ Coverage 51.62% 51.64% +0.02%
===========================================
Files 108 108
Lines 4533 4533
===========================================
+ Hits 2340 2341 +1
+ Misses 2193 2192 -1
Continue to review full report at Codecov.
|
Fix security issues with old gems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version 1.4.0