Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add es-VE (Spanish as spoken in Venezuela) profanities to es.json #21

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Add es-VE (Spanish as spoken in Venezuela) profanities to es.json #21

merged 2 commits into from
Oct 29, 2018

Conversation

Leodau
Copy link
Contributor

@Leodau Leodau commented Oct 26, 2018

fixes #20

@Leodau Leodau mentioned this pull request Oct 26, 2018
Open
@wooorm
Copy link
Member

wooorm commented Oct 27, 2018

@MrBenJ May I ask you to review these changes?

@Leodau Don’t worry about the Travis failure. That’s an issue unrelated to your code.

@wooorm wooorm changed the title feat(Profanity_ES): Adding Venezuelan dialect profanities. Add es-VE (Spanish as spoken in Venezuela) profanities to es.json Oct 27, 2018
MrBenJ
MrBenJ reviewed Oct 28, 2018
View reviewed changes
Copy link
Contributor

@MrBenJ MrBenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I left some comments on the file. I noticed that some words like fiesta de putas could trigger double the errors (for putas and fiesta de putas). Let me know if anything looks out of place.

es.json Outdated
"fiesta de pollas": 2,
"fiesta de putas": 2,
"fiesta de culos": 2,
"fiesta de imbeciles": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to create a plural version for imbecil and put imbeciles on line 303. Putting words like this (like putas) will also cause double errors to be caught in the parser too should this phrase arise.

es.json Outdated
@@ -236,6 +248,11 @@
"fantoche": 2,
"fariseo": 2,
"fiesta de salchichas": 2,
"fiesta de pollas": 2,
"fiesta de putas": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have puta and putas. If fiesta de putas appears, it'll trigger two errors. I think we might be able to remove this, but I'll leave that decision up to the repo owner.

es.json
@@ -390,6 +417,7 @@
"paquete": 1,
"pardillo": 2,
"parguela": 2,
"pargo": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might definitely be a locale thing, but isn't pargo just a fish? What's it referring to that could be offensive?

Copy link
Contributor Author

@Leodau Leodau Oct 28, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did find atleast 20+ geo/local words in the file that don't mean anything offensive to me also, are you a native spanish speaker?, as i said, these aditions are related to "Spanish as spoken in Venezuela". Btw. Pargo is a fish, but it is almost everytime used as another "marico/gay" word.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My coworker who helped me put this list of words together is a native Spanish speaker (Mexico City). I'm not a native speaker, but I do know enough to be functional :). I wouldn't say I'm the most fluent, but I know enough to get by.

I did do a quick search and saw that pargo is (offensive) slang for homosexual, so I think it can stay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have tons of geo/local slangs in latin-america.
:)

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 28, 2018

@wooorm - It looks like for the most part this list that @Leodau is pretty solid (Thank you so much!).

I did find some doubles in there and commented on them in the review. Not sure what your policies on this is, but let us know and we'll do our best to get this in working order for you :).

Thanks again! You are all awesome!

Leodau
Leodau commented Oct 28, 2018
View reviewed changes
Copy link
Contributor Author

@Leodau Leodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid weird multiple catching with the plural forms 👍

es.json
@@ -390,6 +417,7 @@
"paquete": 1,
"pardillo": 2,
"parguela": 2,
"pargo": 2,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have tons of geo/local slangs in latin-america.
:)

@Murderlon Murderlon assigned Murderlon and unassigned Murderlon Oct 29, 2018
@Murderlon Murderlon merged commit 37c19ad into words:master Oct 29, 2018
@Murderlon
Copy link
Member

@Leodau @MrBenJ Good stuff, thanks!

@wooorm
Copy link
Member

wooorm commented Oct 29, 2018

@Leodau @MrBenJ @Murderlon Thanks all!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBenJ MrBenJ MrBenJ approved these changes

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profanities for Spanish as spoken in Venezuela
4 participants
@Leodau @wooorm @MrBenJ @Murderlon