Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organ #8

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Organ #8

wants to merge 6 commits into from

Conversation

quoyi
Copy link
Contributor

@quoyi quoyi commented Sep 9, 2020

No description provided.

@quoyi
Copy link
Contributor Author

quoyi commented Sep 9, 2020

@qinmingyuan 重点关注 create 后的跳转链接,其他修改都是格式调整。

@qinmingyuan
Copy link
Member

我觉得组织不应该轻易删除,而是调整为离开组织比较稳妥。

  1. 只有组织的创建者 owned: true , 可以删除;
  2. 其他人只能离开组织,即删除 member.

@quoyi
Copy link
Contributor Author

quoyi commented Sep 9, 2020

我觉得组织不应该轻易删除,而是调整为离开组织比较稳妥。

  1. 只有组织的创建者 owned: true , 可以删除;
  2. 其他人只能离开组织,即删除 member.
  1. 从管理平台的功能上面讲应该是要删除功能的,如果不想物理删除可以考虑”标记删除“,查询的时候显示并标识”已删除“比较妥当。
  2. 离开功能是需要的,另外组织管理者 ”修改组织成员“ 就相当于删除 member。

@qinmingyuan
Copy link
Member

现在的代码逻辑是:组织内的任何一个人都有权限删除该组织,肯定有问题啊


def organ_params
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style 不要调整,不改代码风格,这个是协作的一个原则。我是故意采用格式:

permit(
  :name,
  :logo
)

<%= ef.text_field :name, required: true %>
<%= ef.file_field :logo %>
<%= ef.text_field :name, required: true, class: 'input is-small', label: { class: 'label is-small' } %>
<%= ef.file_field :logo, class: 'input is-small', label: { class: 'label is-small' } %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是统一设置,没必要在这里改样式。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants