Fixing pagination of S3 fetches #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching more than 1000 files in a bucket, pagination was broken, leading to an infinite loop.
moufmouf
added a commit
that referenced
this pull request
Mar 27, 2024
The previous fix applied in #3807 was incomplete and worked in Minio but not S3. S3 does not put a marker if there is no delimiter. We fix this by moving everything to the new listObjects V2 method that always includes a continuationToken. We also migrate all listObjects to listObjectsv2
moufmouf
added a commit
that referenced
this pull request
Mar 27, 2024
The previous fix applied in #3807 was incomplete and worked in Minio but not S3. S3 does not put a marker if there is no delimiter. We fix this by moving everything to the new listObjects V2 method that always includes a continuationToken. We also migrate all listObjects to listObjectsv2
moufmouf
added a commit
that referenced
this pull request
Mar 27, 2024
The previous fix applied in #3807 was incomplete and worked in Minio but not S3. S3 does not put a marker if there is no delimiter. We fix this by moving everything to the new listObjects V2 method that always includes a continuationToken. We also migrate all listObjects to listObjectsv2
moufmouf
added a commit
that referenced
this pull request
Mar 27, 2024
The previous fix applied in #3807 was incomplete and worked in Minio but not S3. S3 does not put a marker if there is no delimiter. We fix this by moving everything to the new listObjects V2 method that always includes a continuationToken. We also migrate all listObjects to listObjectsv2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching more than 1000 files in a bucket, pagination was broken, leading to an infinite loop.
Also: Fix the first part of screen sharing error
Issue: when one user open and close screen sharing, the second user in the bubble discussion cannot open new screen sharing.