Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The europe.py file starts to be quite big, should we start splitting calendars? #135

Closed
Natim opened this issue Jun 21, 2016 · 6 comments
Closed

Comments

@Natim
Copy link
Contributor

Natim commented Jun 21, 2016

I think a file per country could make it easier to maintain.

europe.py → europe/_init.py, europe/estonia.py, europe/france.py, europe/swiss.py, etc...

@brunobord
Copy link
Member

good idea

@Natim
Copy link
Contributor Author

Natim commented Jun 21, 2016

I am starting the work here: #136
But I feel like usa.py and core.py might need to have the same treatment.

@brunobord
Copy link
Member

But I feel like usa.py and core.py might need to have the same treatment.

AFAICT, usa.py won't evolve, since all the US states are in, and, except if global geopolitics changes happen, there won't be new states. Maybe, at some point, if Asian calendars are incoming, we may have to split (too) big modules

@Natim
Copy link
Contributor Author

Natim commented Jun 22, 2016

Does it means that I do not need to split usa.py and core.py ?

@brunobord
Copy link
Member

@Natim for the "usa.py" I don't see the point. for the "core.py", I don't know for sure, but I wouldn't do it in this PR, maybe in another, when #135 is closed.

@brunobord
Copy link
Member

merged, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants