Refactor get_weekend_days to use WEEKEND_DAYS more intelligently #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2017 14:12
…ne the weekend, otherwise the calendar author needs to implement get_weekend_days as before.
brunobord
requested changes
May 11, 2017
There was a problem hiding this comment.
I think that you could amend your pull-request with a changelog entry, as specified in the github pull-request template
- Changelog amended with a mention describing your changes.
brunobord
reviewed
May 11, 2017
| @@ -82,6 +82,12 @@ def test_year_2013(self): | |||
| self.assertIn(date(2013, 10, 18), holidays) # eid al adha | |||
| self.assertIn(date(2013, 12, 18), holidays) # National Day | |||
|
|
|||
| def test_weekend(self): | |||
There was a problem hiding this comment.
is this test failing without your patch? I'm unsure...
There was a problem hiding this comment.
never mind, you're right.
As soon as the changelog will be amended in your PR and merged, I may start to work on a minor refactor, and adding tests on the test_core module, but don't worry, your patch is an excellent step in the right direction!
Natim
approved these changes
May 11, 2017
|
@brunobord Apologies for missing that, my bad. |
brunobord
approved these changes
May 11, 2017
|
Congrats for your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If WEEKEND_DAYS is provided in the calendar class then use it to define the weekend, otherwise the calendar author needs to implement get_weekend_days as before.