Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Christmas Day is two times in Slovakia #205

Closed
ghost opened this issue Jun 6, 2017 · 3 comments · Fixed by #207
Closed

Christmas Day is two times in Slovakia #205

ghost opened this issue Jun 6, 2017 · 3 comments · Fixed by #207

Comments

@ghost
Copy link

ghost commented Jun 6, 2017

Hi again.

In slovakia, christmas day occure 2 times.

sk = Slovakia()
sk.holidays()
[
(datetime.date(2017, 1, 1), 'Day of the Establishment of the Slovak Republic'), 
(datetime.date(2017, 1, 1), 'New year'), 
(datetime.date(2017, 1, 6), 'Epiphany'), 
(datetime.date(2017, 4, 14), 'Good Friday'), 
(datetime.date(2017, 4, 17), 'Easter Monday'), 
(datetime.date(2017, 5, 1), 'Labour Day'), 
(datetime.date(2017, 5, 8), 'Liberation Day'), 
(datetime.date(2017, 7, 5), 'Saints Cyril and Methodius Day'), 
(datetime.date(2017, 8, 29), 'Slovak National Uprising anniversary'), 
(datetime.date(2017, 9, 1), 'Day of the Constitution of the Slovak Republic'),
(datetime.date(2017, 9, 15), 'Day of Blessed Virgin Mary, patron saint of Slovakia'), (datetime.date(2017, 11, 1), 'All Saints\xe2\x80\x99 Day'), 
(datetime.date(2017, 11, 17), 'Struggle for Freedom and Democracy Day'), 
(datetime.date(2017, 12, 24), 'Christmas Eve'), 
(datetime.date(2017, 12, 25), 'Christmas Day'), 
(datetime.date(2017, 12, 25), 'Christmas Day'), 
(datetime.date(2017, 12, 26), "St. Stephen's Day (The Second Christmas Day)")
]

I think is because of:
In ChristianMixin you have include_christmas = True
and in Slovakia class you have (12, 25, "Christmas Day"),

@brunobord
Copy link
Member

oh, yes indeed. could you please submit a PR to fix this?

brunobord added a commit that referenced this issue Jun 8, 2017
refs #205

While I was at it, I've reconfigured some variable christian days that were included in the `ChristianMixin`, but were configured as "fixed days".

* All saints day
* Christmas eve
* St Stephen's day
@brunobord
Copy link
Member

never mind, I took half an hour to solve this.

@brunobord
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant