Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformation Day is now in more states (Germany) #295

Closed
johnberroa opened this issue Nov 26, 2018 · 3 comments · Fixed by #300
Closed

Reformation Day is now in more states (Germany) #295

johnberroa opened this issue Nov 26, 2018 · 3 comments · Fixed by #300
Projects

Comments

@johnberroa
Copy link

https://www.timeanddate.com/holidays/germany/reformation-day

Currently there are 9 states that celebrate it, versus the 5 or so of previous years.

@brunobord
Copy link
Member

mmmm interesting. I'll need to investigate on this, thanks for the information.

@brunobord
Copy link
Member

information: https://en.wikipedia.org/wiki/Public_holidays_in_Germany

looks like it became a holiday for all states in 2017, but only Four states decided to permanently adopt the Reformation Day as permanent holiday starting of 2018.
This needs further investigation.

@brunobord brunobord added this to To Do in Workalendar Nov 29, 2018
@brunobord brunobord moved this from To Do to Working in Workalendar Dec 6, 2018
brunobord added a commit that referenced this issue Dec 6, 2018
* Some German states include reformation day since the "beginning",
* In 2017, all states had Reformation Day as a holiday to celebrate the 500th anniversary of the Reformation,
* Starting of 2018, 4 states added Reformation Day as a holiday.

closes #295
brunobord added a commit that referenced this issue Dec 6, 2018
* Some German states include reformation day since the "beginning",
* In 2017, all states had Reformation Day as a holiday to celebrate the 500th anniversary of the Reformation,
* Starting of 2018, 4 states added Reformation Day as a holiday.

closes #295
brunobord added a commit that referenced this issue Dec 6, 2018
Only bugfixes:

- Added DEEPAVALI days for 2019 and 2020, thx @pvalenti (#282).
- Fixed Germany Reformation Day miscalculation. Some German states include Reformation Day since the "beginning" ; in 2017, all states included Reformation Day as a holiday (500th anniversary of the Reformation) ; starting of 2018, 4 states added Reformation Day (#295).
@brunobord
Copy link
Member

Fixed and released on v3.2.1 - happy upgrading!
https://pypi.org/project/workalendar/3.2.1/

@brunobord brunobord moved this from Working to Done in Workalendar Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Workalendar
  
Done/Closed/Published
Development

Successfully merging a pull request may close this issue.

2 participants