Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scotland #31

Closed
brunobord opened this issue Dec 2, 2013 · 7 comments · Fixed by #320
Closed

Scotland #31

brunobord opened this issue Dec 2, 2013 · 7 comments · Fixed by #320
Assignees
@brunobord
Labels
calendar
Projects
Workalendar
Milestone
v0.2

Comments

@brunobord
Copy link
Member

Scotland calendar doesn't look like a piece of cake, they've got extra days for cities (like Glasgow, or Inverness...)

probably won't be able to do it for the advent calendar, but I'll try to integrate it as quickly as I can.
@brunobord brunobord self-assigned this May 16, 2014
@brunobord
Copy link
Member Author

working on it right now. It's going to take time...

brunobord added a commit that referenced this issue May 17, 2014
@brunobord
refs #31 -- scotland "root" calendar
d19fdf7
brunobord added a commit that referenced this issue May 17, 2014
@brunobord
refs #31 -- Scotland calendars (yes, tons of them)
29bade5
brunobord added a commit that referenced this issue May 17, 2014
@brunobord
refs #31 -- Edinburgh and Perth Victoria Day
b7236a9
brunobord added a commit that referenced this issue May 17, 2014
@brunobord
refs #31 -- Spring holiday as Last Monday in May
4027ba0
brunobord added a commit that referenced this issue May 17, 2014
@brunobord
refs #31 -- victoria day for Paisley and Dundee
975693f
@atmclarke
Copy link
Contributor

Hey,
I live in Edinburgh so I can give you information about how holidays work in practice. So in May, everyone has the first Monday in May as a holiday. The schools, council, university, buses (they still run, just on a Saturday timetable instead) and a small number of retailers/shops observe Victoria day, with the rest observing the last Monday. This is generally the pattern across Scotland, that you'll get either the local public holiday or the nearby national holiday, but not both.

I could see it being helpful to construct an Edinburgh calendar for 2014 that would know the 'linked' holiday:

  [... (date(2014, 5, 5), "May Day Public Holiday"), (date(2014, 5, 19), "Victoria Day Public Holiday (or Spring Bank Holiday)", (date(2014, 5, 26), "Spring Bank Holiday (or Victoria Day Public Holiday)")...]

Also, St. Andrews Day isn't in practice a non working day - I don't know of anyone who actually doesn't work on that day. See http://www.scotland.gov.uk/Topics/People/standrewsdaybill/questionsanswers for more details; so I don't think it should be included as a non-working day.

Hope that is helpful,
Martin

@brunobord
Copy link
Member Author

definitely helpful, thanks a million for this information.

@stuaxo
Copy link

stuaxo commented Oct 24, 2014

Hi
Is there any chance this will get merged. - Working on a scottish app at the moment and it would be pretty useful.

Cheers
S

@brunobord
Copy link
Member Author

Hello,

Unfortunately, this branch is still work in progress, because Scotland has a lot of special cases and I couldn't find time yet to work on them.

@stuaxo
Copy link

stuaxo commented Oct 24, 2014

Heh - no probs :)

The architecture makes it easy enough to add specific calendars for organisations.. this is a useful library.

@brunobord brunobord added this to Warming up in Workalendar Jun 15, 2017
@brunobord brunobord moved this from Warming up to Working in Workalendar Aug 30, 2018
@brunobord
Copy link
Member Author

Reference: https://en.wikipedia.org/wiki/Public_and_bank_holidays_in_Scotland

brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
Adding Scotland calendars
b4dece3 
refs #31

* Scotland base calendars
* Major towns and cities have their own calendars

Four years after the beginning, I'm back.
brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
Added a warning for Scotland calendars
d9c39fd 
refs #31
brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
Adding Scotland calendars
55720dc 
refs #31

* Scotland base calendars
* Major towns and cities have their own calendars

Four years after the beginning, I'm back.
brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
Added a warning for Scotland calendars
07ccb88 
refs #31
@brunobord brunobord mentioned this issue Feb 7, 2019
Merged
5 tasks
brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
Adding Scotland calendars
fb35a15 
refs #31

* Scotland base calendars
* Major towns and cities have their own calendars

Four years after the beginning, I'm back.
brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
Added a warning for Scotland calendars
d8e48f5 
refs #31
@brunobord brunobord moved this from Working to Done in Workalendar Feb 7, 2019
brunobord added a commit that referenced this issue Feb 7, 2019
@brunobord
v4.1.0
afcbfc2 
**New calendars**

*WARNING* Scotland (sub)calendars are highly experimental and because of their very puzzling rules, may be false. Please use them with care.

- Added Scotland calendars, i.e. Scotland, Aberdeen, Angus, Arbroath, Ayr, Carnoustie & Monifieth, Clydebank, Dumfries & Galloway, Dundee, East Dunbartonshire, Edinburgh, Elgin, Falkirk, Fife, Galashiels, Glasgow, Hawick, Inverclyde, Inverness, Kilmarnock, Lochaber, Monifieth, North Lanarkshire, Paisley, Perth, Scottish Borders, South Lanarkshire, Stirling, and West Dunbartonshire (#31).

**Bugfixes**

- Fixed United Kingdom bank holiday for 2002 and 2012, thx @ludsoft (#315).
- Fix a small flake8 issue with wrong indentation (#319).
- Fix Russia "Day of Unity" date, set to November 4th, thx @alexitkes for the bug report (#317).
@brunobord brunobord mentioned this issue Feb 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobord brunobord

Labels
calendar
Projects
Workalendar
  
Done/Closed/Published
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

Scotland calendars workalendar/workalendar
3 participants
@brunobord @stuaxo @atmclarke