Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

America: Cayman Island calendar #328

Closed
toloco opened this issue Feb 18, 2019 · 10 comments
Closed

America: Cayman Island calendar #328

toloco opened this issue Feb 18, 2019 · 10 comments

Comments

@toloco
Copy link

toloco commented Feb 18, 2019 •
edited

Add support for Cayman Island calendar

As many banks and institutions are working with Cayman Islands funds or banks I believe this will be very useful and help to rocket this library at the corporate level.
@brunobord
Copy link
Member

I wouldn't have thought about this library this "corporate" way, but thank you for your suggestion.
I'll add this new calendar as soon as I can.

Or maybe you could try by opening a pull-request? It's documented here and I'd be happy to review it!

For the record: https://en.wikipedia.org/wiki/Public_holidays_in_the_Cayman_Islands

@Natim
Copy link
Contributor

Natim commented Feb 18, 2019 •
edited

The title says America but as far as I know Cayman's Island are a British Overseas Territory. Shall we put them in the america.py file or in the eu.py file? 🚀

@toloco
Copy link
Author

toloco commented Feb 18, 2019

I said America as it sounds more geographically correct, but your point makes more sense.

@brunobord
Copy link
Member

mmmm both? j/k
I'd be tempted to say "europe" namespace, since it's attached to the British Crown.

@toloco
Copy link
Author

toloco commented Feb 18, 2019

By the way, do you get movable public holidays hardcoded or using something else? like parsing a government website

@Natim Natim mentioned this issue Feb 18, 2019
Merged
5 tasks
@Natim
Copy link
Contributor

Natim commented Feb 18, 2019

I started something in PR #329 what bother's me the most is the Queen Birthday. I will move it in europe.

@toloco
Copy link
Author

toloco commented Feb 18, 2019

oh sweet, thanks I was just adding it

@Natim
Copy link
Contributor

Natim commented Feb 18, 2019 •
edited

Sorry about that 😕 Feel free to review my work and if you have better ideas for the especially for queen's birthday feel free to tell me.

@Natim
Copy link
Contributor

Natim commented Feb 18, 2019

For the record: https://en.wikipedia.org/wiki/Public_holidays_in_the_Cayman_Islands

http://www.gov.ky/portal/page/portal/cighome/publicholidays

brunobord added a commit that referenced this issue Feb 21, 2019
@brunobord
v4.2.0
e3ce1a7 
**New calendars**

- Added several US territories and other specific calendars:
  - American Samoa territory (#218).
  - Chicago, Illinois (#220).
  - Guam territory (#219).
  - Suffolk County, Massachusetts (#222).
- Added Cayman Islands, British Overseas Territory (#328)
@brunobord brunobord mentioned this issue Feb 21, 2019
Merged
3 tasks
brunobord added a commit that referenced this issue Feb 21, 2019
@brunobord
v4.2.0
506db5f 
**New calendars**

- Added several US territories and other specific calendars:
  - American Samoa territory (#218).
  - Chicago, Illinois (#220).
  - Guam territory (#219).
  - Suffolk County, Massachusetts (#222).
- Added Cayman Islands, British Overseas Territory (#328)
@brunobord
Copy link
Member

merged, tagged and released: https://github.com/peopledoc/workalendar/releases/tag/4.2.0

Also available on PyPI. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunobord @Natim @toloco