Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add South African 2019 National Elections as holiday #350

Closed
wants to merge 2 commits into from
Closed

Add South African 2019 National Elections as holiday #350

wants to merge 2 commits into from

Conversation

RichardOB
Copy link
Contributor

@RichardOB RichardOB commented May 10, 2019 •
edited

refs #

Added May 8th as a South African Holiday for the 2019 National Elections. https://en.wikipedia.org/wiki/2019_South_African_general_election

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes.

brunobord
brunobord requested changes May 15, 2019
View reviewed changes
workalendar/tests/test_registry_africa.py

# variable days
self.assertIn(date(2019, 5, 8), holidays) # 2019 National Elections
self.assertNotIn(date(2017, 5, 8), holidays)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hem... no it won't work like this. You're fetching the "2019" holidays, and of course, the 2017-05-08 is not in the holiday set.

Let me suggest something:

Suggested change
self.assertNotIn(date(2017, 5, 8), holidays)
holidays_2017 = self.cal.holidays_set(2017)
self.assertNotIn(date(2017, 5, 8), holidays_2017)

@brunobord
Copy link
Member

brunobord commented May 17, 2019 •
edited

@RichardOB
time is short, and I've got the time to work on this today. Do you want me to take your work, fix the tiny bugs and merge it ASAP? (I could make a hotfix release afterwards).

@RichardOB
Copy link
Contributor Author

@RichardOB
time is short, and I've got the time to work on this today. Do you want me to take your work, fix the tiny bugs and merge it ASAP? (I could make a hotfix release afterwards).

Hi Bruno,

That would be great! Sorry that I haven't addressed your latest comment and left you hanging for a while.

@brunobord
Copy link
Member

Heh. don't worry, it's okay. We all have lives :o) I'll keep you updated.

@brunobord brunobord added this to Working in Workalendar May 17, 2019
@brunobord brunobord mentioned this pull request May 17, 2019
Merged
Workalendar automation moved this from Working to Done May 17, 2019
brunobord added a commit that referenced this pull request May 17, 2019
@brunobord
v4.4.0
4190e7d 
**WARNING**: This release will be the last one to support Python 3.4, which has [reached its End of Life and has been retired](https://www.python.org/dev/peps/pep-0429/#release-schedule). Please upgrade.

**Added calendar**

- Added California specific calendars: California Education, Berkeley, San Francisco, West Hollywood (#215).

**Fixes**

- Added a few refactors and tests for Australia Capital Territory holiday named "Family & Community Day", that lasted from 2007 to 2017 (#25).
- Added South African 2019 National Elections as holiday (#350), by @RichardOB.
@brunobord brunobord mentioned this pull request May 17, 2019
Merged
@brunobord
Copy link
Member

Version 4.4.0 has been released and is available at PyPI, grab it while it's hot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobord brunobord brunobord requested changes

Assignees
No one assigned
Labels
None yet
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RichardOB @brunobord