Australia: Family & Community Day #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobord
added a commit
that referenced
this pull request
Apr 12, 2019
…ay named "Family & Community Day", that lasted from 2007 to 2017 closes #25
…ay named "Family & Community Day", that lasted from 2007 to 2017 closes #25
brunobord
force-pushed
the
25-australia-family-day
branch
from
372e34b
to
5353978
Compare
brunobord
added a commit
that referenced
this pull request
May 17, 2019
**WARNING**: This release will be the last one to support Python 3.4, which has [reached its End of Life and has been retired](https://www.python.org/dev/peps/pep-0429/#release-schedule). Please upgrade. **Added calendar** - Added California specific calendars: California Education, Berkeley, San Francisco, West Hollywood (#215). **Fixes** - Added a few refactors and tests for Australia Capital Territory holiday named "Family & Community Day", that lasted from 2007 to 2017 (#25). - Added South African 2019 National Elections as holiday (#350), by @RichardOB.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Family & Community Day follows a "weird" non-mathematical rule
https://en.wikipedia.org/wiki/Family_Day
Will try to find a better way to handle this.This PR explicits a bit better how this day is assigned, and adds a few tests to make sure that boundaries are correctly respected.