Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python3 wheels #366

Closed
brunobord opened this issue Jun 7, 2019 · 4 comments · Fixed by #383
Closed

Build Python3 wheels #366

brunobord opened this issue Jun 7, 2019 · 4 comments · Fixed by #383
Projects

Comments

@brunobord
Copy link
Member

This needs to be scripted:

  • get only releases that are/were compatible with Python3
  • eventually check that we can build them using Python 3.6, even if they weren't Py3.6 compatible.
  • don't forget to remove the build/ repository before rebuilding (following @ewjoachim's advice)
  • push to PyPI
@brunobord brunobord added this to Warming up in Workalendar Jun 7, 2019
brunobord added a commit to brunobord/workalendar that referenced this issue Jun 7, 2019
released on 2019-03-15

**New Calendar**

- Added Barbados by @ludsoft.

**Fixes**

- Added isolated tests for shifting mechanics in USA calendars - previously untested (workalendar#335).
- Added Berlin specific holidays (workalendar#340).
- Added several one-off public holidays to UK calendar (workalendar#366).
@ewjoachim
Copy link
Contributor

(if you're building wheels for py3 only, then you won't need the "universal = True" that everyone puts everywhere)

@brunobord brunobord moved this from Warming up to Working in Workalendar Jul 4, 2019
@brunobord
Copy link
Member Author

here's the script I've used (yes, it could've been bash, but I never remember how to make a loop):

from shell import shell
from distutils.version import StrictVersion

result = shell('git tag')
tags = result.output()
tags = filter(lambda x: not x.startswith('v'), tags)  # That was a mistake
tags = filter(lambda x: StrictVersion(x) >= StrictVersion("1.0.0"), tags)

for tag in tags:
    print(tag)
    shell(f'git checkout {tag}')
    shell('rm -Rf build/')
    result = shell('python setup.py bdist_wheel')
    if result.code:
        print(result.errors())

shell('git checkout master')

@brunobord
Copy link
Member Author

currently uploading every wheel from 1.0.0 to the latest release without any Py3 wheel.

brunobord added a commit that referenced this issue Jul 4, 2019
Workalendar automation moved this from Working to Done Jul 4, 2019
@ewjoachim
Copy link
Contributor

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Workalendar
  
Done/Closed/Published
Development

Successfully merging a pull request may close this issue.

2 participants