Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geneva Calendar #420

Closed
cwittlinger opened this issue Nov 18, 2019 · 2 comments
Closed

Geneva Calendar #420

cwittlinger opened this issue Nov 18, 2019 · 2 comments
Projects
Workalendar

Comments

@cwittlinger
Copy link
Contributor

The calendar in Geneva is the same as the Swiss calendar, with the following exceptions:

  • Berchtold's day is not celebrated (2.1)
  • They celebrate two additional holidays:
    • Jeûne genevois or Genevan Fast: Thursday following the first Sunday of September
    • Creation of the Geneva Republic: Celebrated on the 31.12

I will create a PR soon.
@cwittlinger cwittlinger mentioned this issue Nov 18, 2019
Merged
5 tasks
@cwittlinger
Copy link
Contributor Author

I've created a pull request, which is ready to be merged (#421)

@brunobord
Copy link
Member

Geneva calendar has been added to the 7.1.1 release and is available from PyPI. Happy upgrading, and thank you for this cool contribution!

brunobord added a commit that referenced this issue Nov 22, 2019
@brunobord
Refactored the computation of Genevan Fast holiday
0d8969f 
* using the available API to get the first SUN of september, having a more readable code
* using a more "standard" way to return the holiday, with a tuple (date, label)

refs #420
@brunobord brunobord mentioned this issue Nov 22, 2019
Merged
2 tasks
@brunobord brunobord added this to Warming up in Workalendar via automation Nov 22, 2019
@brunobord brunobord moved this from Warming up to Done in Workalendar Nov 22, 2019
brunobord added a commit that referenced this issue Dec 6, 2019
@brunobord
v7.2.0
0d53e75 
**New calendars**

- Added Serbia calendar, by @apelloni (#435).
- Added Argentina calendar, by @ftatarli (#419).

**Other changes**

- Update China's public holidays for 2020, thx @nut-free (#429).
- Update Malaysia and Singapore for 2021 (Deepavali + Thaipusam) by @jack-pace (#432).
- Small refactorings on the Gevena (Switzerland) holiday class, thx to @cw-intellineers (#420).
@brunobord brunobord mentioned this issue Dec 6, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunobord @cwittlinger