Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 2 support #442

Closed
7 tasks done
brunobord opened this issue Dec 13, 2019 · 1 comment · Fixed by #446
Closed
7 tasks done

Drop Python 2 support #442

brunobord opened this issue Dec 13, 2019 · 1 comment · Fixed by #446
Projects
Workalendar

Comments

@brunobord
Copy link
Member

brunobord commented Dec 13, 2019 •
edited

This is a subtask of #330

  • remove from __future__
  • remove coding headers
  • Look after super() methods.
  • Relative imports
  • class don't need to inherit from object
  • Remove the skipIf(PY2) skipped tests in Scotland and USA tests
  • Update documentation regarding relative/absolute imports
@brunobord brunobord added this to Warming up in Workalendar via automation Dec 13, 2019
@brunobord brunobord moved this from Warming up to Working in Workalendar Dec 13, 2019
@Natim
Copy link
Contributor

Natim commented Dec 13, 2019

Refs #443

brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Drop Python 2.7 support
ce3e21b 
refs #442, #330
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Remove "coding" headers
a0ddaa8 
refs #442
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Remove __future__ imports
b5bd9c5 
refs #442
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Remove Python 2 styled super() calls
43684d2 
refs #442
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Remove absolute imports and replace them by relative ones
0327481 
refs #442
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Remove object inheritance for mixin and "non-calendar" classes
5bf0428 
refs #442
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Removed conditional skip for tests that didn't work in Python 2
1bf5de7 
refs #442
brunobord added a commit that referenced this issue Dec 20, 2019
@brunobord
Added a note in the Contributing document about coding standards
b26ffc9 
refs #442
@brunobord brunobord mentioned this issue Dec 20, 2019
Merged
2 tasks
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Drop Python 2.7 support
7558b6b 
refs #442, #330
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Remove "coding" headers
e7d9522 
refs #442
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Remove __future__ imports
00af198 
refs #442
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Remove Python 2 styled super() calls
2d76d32 
refs #442
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Remove absolute imports and replace them by relative ones
88729e4 
refs #442
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Remove object inheritance for mixin and "non-calendar" classes
9b9bbbb 
refs #442
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Removed conditional skip for tests that didn't work in Python 2
f0b5c11 
refs #442
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
Added a note in the Contributing document about coding standards
d89eb0f 
refs #442
Workalendar automation moved this from Working to Done Jan 10, 2020
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
v8.0.0
e66d30c 
- **BREAKING CHANGE** Drop Support for Python 2 - EOL January 1st 2020 (#442).
- Added Ukraine calendar, by @apelloni.
- Small cleanup in the ``.travis.yml`` file, thx to @Natim.

**ISO Registry API Change**

- Changes in the ``registry.items()`` method API.
  - This method is aliased to ``get_calendars()``. In a near release, the ``items()`` method will change its purpose.
  - The ``get_calendars()`` method accepts an empty/missing ``region_codes`` argument to retrieve the full registry. Please see the [ISO Registry documentation](https://peopledoc.github.io/workalendar/iso-registry.html) for extensive usage docs (#403, #375).
@brunobord brunobord mentioned this issue Jan 10, 2020
Merged
14 tasks
brunobord added a commit that referenced this issue Jan 10, 2020
@brunobord
v8.0.0
669129d 
- **BREAKING CHANGE** Drop Support for Python 2 - EOL January 1st 2020 (#442).
- Added Ukraine calendar, by @apelloni.
- Small cleanup in the ``.travis.yml`` file, thx to @Natim.

**ISO Registry API Change**

- Changes in the ``registry.items()`` method API.
  - This method is aliased to ``get_calendars()``. In a near release, the ``items()`` method will change its purpose.
  - The ``get_calendars()`` method accepts an empty/missing ``region_codes`` argument to retrieve the full registry. Please see the [ISO Registry documentation](https://peopledoc.github.io/workalendar/iso-registry.html) for extensive usage docs (#403, #375).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop python2 support workalendar/workalendar
2 participants
@brunobord @Natim