Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix: Labour day / International Labour Day should be in core #467

Closed
3 tasks done
brunobord opened this issue Feb 21, 2020 · 0 comments · Fixed by #532
Closed
3 tasks done

Quick fix: Labour day / International Labour Day should be in core #467

brunobord opened this issue Feb 21, 2020 · 0 comments · Fixed by #532
Assignees
@brunobord
Labels
small improvement Small steps, but nice to have
Projects
Workalendar

Comments

@brunobord
Copy link
Member

brunobord commented Feb 21, 2020 •
edited

This international holiday appears in a lot of calendars as fixed holiday.
When its date is set to May 1st, it should eventually be activated by a flag and has its standard label (that could be overridden sometimes).

  • Add it to core.Calendar with a deactivated flag,
  • Activate it for the countries + add the label test if needed
  • Edit the contributing.md documentation to explain this flag behaviour

Checksum: generate the "all holidays" for all tested calendars on master and compare with the WIP branch.
@brunobord brunobord added feature small improvement Small steps, but nice to have and removed feature labels Feb 21, 2020
@brunobord brunobord added this to Warming up in Workalendar via automation Jun 12, 2020
@brunobord brunobord moved this from Warming up to Working in Workalendar Jun 12, 2020
@brunobord brunobord self-assigned this Jun 12, 2020
brunobord added a commit that referenced this issue Jul 17, 2020
@brunobord
Migrating Labour Day as a worldwide holiday
4eb7628 
* Labour Day is handled at the higher level (`core.Calendar`).
* Generalized this flag + optional label to 50 countries: Algeria, Angola, Argentina, Austria, Barbados, Belarus, Belgium, Benin, Brazil, Bulgaria, Chile, Colombia, Croatia, Cyprus, Czech Republic, European Central Bank, Finland, France, Germany, Greece, Hong-Kong, Hungary, Iceland, Italy, Ivory Coast, Kenya, Latvia, Lithuania, Luxembourg, Madagascar, Malaysia, Malta, Mexico, Norway, Panama, Paraguay, Poland, Portugal, Romania, Russia, Sao Tome & Principe, Serbia, Singapore, Slovakia, Slovenia, Spain (incl. Catalonia), Sweden, Switzerland, Turkey, Ukraine.
* Contributing documentation amended

refs #467
brunobord added a commit that referenced this issue Jul 17, 2020
@brunobord
Migrating Labour Day as a worldwide holiday
7e9c79c 
* Labour Day is handled at the higher level (`core.Calendar`).
* Generalized this flag + optional label to 50 countries: Algeria, Angola, Argentina, Austria, Barbados, Belarus, Belgium, Benin, Brazil, Bulgaria, Chile, Colombia, Croatia, Cyprus, Czech Republic, European Central Bank, Finland, France, Germany, Greece, Hong-Kong, Hungary, Iceland, Italy, Ivory Coast, Kenya, Latvia, Lithuania, Luxembourg, Madagascar, Malaysia, Malta, Mexico, Norway, Panama, Paraguay, Poland, Portugal, Romania, Russia, Sao Tome & Principe, Serbia, Singapore, Slovakia, Slovenia, Spain (incl. Catalonia), Sweden, Switzerland, Turkey, Ukraine.
* Contributing documentation amended

refs #467
@brunobord brunobord mentioned this issue Jul 17, 2020
Merged
2 tasks
Workalendar automation moved this from Working to Done Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobord brunobord

Labels
small improvement Small steps, but nice to have
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrating Labour Day as a worldwide holiday workalendar/workalendar
1 participant
@brunobord