Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

America / Argentina has errors in the names of the holidays #476

Closed
cjadeveloper opened this issue Mar 23, 2020 · 3 comments · Fixed by #481
Closed

America / Argentina has errors in the names of the holidays #476

cjadeveloper opened this issue Mar 23, 2020 · 3 comments · Fixed by #481
Labels
Projects

Comments

@cjadeveloper
Copy link

Firts of all, Good Job! I'm testing the last version of workalander and you have a mistake with the holiday's names here and here

The correct names are:

(3, 24, "Día Nacional de la Memoria por la Verdad y la Justicia"),
(4, 2, "Día del Veterano y de los Caídos en la Guerra de Malvinas."),

In addition, the holiday of April 2 was transferred to Tuesday, March 31, 2020, for the only time, due to mandatory and preventive isolation throughout the country. Decree 297/2020

So this would be, for this year, as follows:

(31, 3, "Día del Veterano y de los Caídos en la Guerra de Malvinas."),

oficial source

If you want, I can do a PR with the corrections and add the remaining fixed holidays

@brunobord
Copy link
Member

If you can handle this PR, I'd be glad to review it and integrate it as fast as possible.
Please make sure that the exceptional transfers only happen for the only years concerned by the exceptions.
I'll watch this space ;o)

@brunobord brunobord added the bug label Mar 27, 2020
@brunobord
Copy link
Member

all right, taking over this issue. I'll try to fix this today.

brunobord added a commit that referenced this issue Apr 3, 2020
This holiday was shifted to March 31st because of the coronavirus crisis

refs #476
brunobord added a commit that referenced this issue Apr 3, 2020
@brunobord brunobord added this to Warming up in Workalendar via automation Apr 3, 2020
@brunobord brunobord moved this from Warming up to Working in Workalendar Apr 3, 2020
@brunobord brunobord mentioned this issue Apr 10, 2020
14 tasks
Workalendar automation moved this from Working to Done Apr 10, 2020
@brunobord
Copy link
Member

Latest version was uploaded to PyPI, including this fix. Happy upgrading!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Workalendar
  
Done/Closed/Published
Development

Successfully merging a pull request may close this issue.

2 participants