Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fix: New years Day is almost universal #511

Closed
brunobord opened this issue Jun 12, 2020 · 0 comments · Fixed by #523
Closed

Refactor fix: New years Day is almost universal #511

brunobord opened this issue Jun 12, 2020 · 0 comments · Fixed by #523
Assignees
@brunobord
Labels
small improvement Small steps, but nice to have
Projects
Workalendar

Comments

@brunobord
Copy link
Member

There are only two calendars (Qatar and Israel) until now that don't include New Year's Day as a holiday. it'd be "handy" to integrate this day as a "universal" day, with a flag set to True by default, and disable it for the calendars that don't include NYD.
@brunobord brunobord added the small improvement Small steps, but nice to have label Jun 12, 2020
@brunobord brunobord self-assigned this Jun 12, 2020
@brunobord brunobord added this to Warming up in Workalendar via automation Jun 12, 2020
@brunobord brunobord moved this from Warming up to Working in Workalendar Jun 12, 2020
brunobord added a commit that referenced this issue Jul 3, 2020
@brunobord
Refactoring core classes
14776ef 
* Refactoring the core ``Calendar`` classes / mixins for better understanding. Only one ``Calendar`` subclass should be imported / used in calendar classes, the rest (when possible) should be ``Mixins`` (related to #511).
* Fixed Belarus holidays related to the Orthodox calendar
* Fixed Algeria week-end days
brunobord added a commit that referenced this issue Jul 3, 2020
@brunobord
Declaring the New year's Day as a worldwide holiday
084df47 
To date, there are only two exceptions: Israel & Qatar

refs #511
brunobord added a commit that referenced this issue Jul 3, 2020
@brunobord
Refactoring core classes
b347472 
* Refactoring the core ``Calendar`` classes / mixins for better understanding. Only one ``Calendar`` subclass should be imported / used in calendar classes, the rest (when possible) should be ``Mixins`` (related to #511).
* Fixed Belarus holidays related to the Orthodox calendar
* Fixed Algeria week-end days
brunobord added a commit that referenced this issue Jul 3, 2020
@brunobord
Declaring the New year's Day as a worldwide holiday
56732da 
To date, there are only two exceptions: Israel & Qatar

refs #511
@brunobord brunobord mentioned this issue Jul 10, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Jul 10, 2020
@brunobord
Declaring the New year's Day as a worldwide holiday
b3d7a11 
To date, there are only two exceptions: Israel & Qatar

refs #511
Workalendar automation moved this from Working to Done Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobord brunobord

Labels
small improvement Small steps, but nice to have
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declaring the New year's Day as a worldwide holiday workalendar/workalendar
1 participant
@brunobord