Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spain: calendars for autonomous regions #531

Closed
17 tasks done
brunobord opened this issue Jul 17, 2020 · 2 comments
Closed
17 tasks done

Spain: calendars for autonomous regions #531

brunobord opened this issue Jul 17, 2020 · 2 comments

Comments

@brunobord
Copy link
Member

brunobord commented Jul 17, 2020

The wikipedia page about Public holidays in Spain1 is now displaying holidays for regions other than Catalonia.

Maybe it's time to add them all...

  • Add the calendars with tests
  • Add ISO registry code (test the code)

TODO

  • Andalusia
  • Aragon
  • Castile and León
  • Castilla–La Mancha
  • Canary Islands
  • Catalonia
  • Extremadura
  • Galicia (Spain)
  • Balearic Islands
  • La Rioja
  • Community of Madrid
  • Region of Murcia
  • Navarre
  • Asturias
  • Basque Country
  • Cantabria
  • Valencian Community

Footnotes

  1. https://en.wikipedia.org/wiki/Public_holidays_in_Spain

@brunobord brunobord added this to To Do in Workalendar Jul 17, 2020
@brunobord brunobord moved this from To Do to Working in Workalendar Sep 18, 2020
@brunobord
Copy link
Member Author

Small doubts for ISO codes for Asturias & Murcia.
I've asked @ainarela (super Spanish coworker) and she replied:

so in Asturias seems like one is for the province, and the other for the autonomous community…

I would take the one for the autonomous community, because that is above the province administratively speaking: autonomous communities contain provinces communities can contain several provinces, but in the case of Asturias there is only one, with the same name, so for sure the public holidays are the same but it makes more sense I think to use ES-AS I think

ok, and same thing for Murcia actually :) wikipedia says “region” but it should mean the same as “autonomous community”, and Murcia region has only one province. I think you’re good with ES-MC

brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
that is to say: Andalusia, Aragon, Castile and León, Castilla-La Mancha, Canary Islands, Extremadura, Galicia, Balearic Islands, La Rioja, Community of Madrid, Murcia, Navarre, Asturias, Basque Country, Cantabria, Valencian Community

closes #531
@brunobord brunobord mentioned this issue Oct 9, 2020
5 tasks
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
brunobord added a commit that referenced this issue Oct 9, 2020
Workalendar automation moved this from Working to Done Oct 9, 2020
@brunobord
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Workalendar
  
Done/Closed/Published
Development

No branches or pull requests

1 participant