Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py to setup.cfg fixes #587

Closed
brunobord opened this issue Nov 13, 2020 · 0 comments · Fixed by #588
Closed

setup.py to setup.cfg fixes #587

brunobord opened this issue Nov 13, 2020 · 0 comments · Fixed by #588

Comments

@brunobord
Copy link
Member

there are a few references to setup.py:

  • in the PR template, it's just a documentation fix, but it'll be nice,
  • in the ci.yml files: the cache hash is calculated from the setup.py contents. If it doesn't change, the cache won't be rightfully invalidated. This fix is a bit more important.
brunobord added a commit that referenced this issue Nov 13, 2020
@brunobord
Fixed Pull Request template to reference setup.cfg
4e46708 
refs #587
brunobord added a commit that referenced this issue Nov 13, 2020
@brunobord
Use setup.cfg file in the key to cache in ci.yml file
e489f29 
refs #587
@brunobord brunobord mentioned this issue Nov 13, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Nov 13, 2020
@brunobord
v13.0.0
92ac494 
**Calendars**

- Add optional school holidays to Netherlands calendar, by @Flix6x (#556).
- Add optional carnival to Netherlands calendar.

**Documentation**

- Moving the `contributing.md` file to the `docs/` directory (#573).
- Changed from `setup.py` to a nice `setup.cfg` file, thanks @ewjoachim (#576).
- Added documentation about class options (#572).
- Converted `README.rst` file into `README.md` (#575).
- Fixed Pull Request template to reference `setup.cfg` (#587).

**Other changes**

- Switched from Travis CI to Github Actions for CI jobs, thanks to @mgu.
- Added support of Python 3.9 (#557).
- Changed from `setup.py` to a nice `setup.cfg` file, thanks @ewjoachim (#576).
- Use the `setup.cfg` file in the key to cache in `ci.yml` file (#587).
- [OBSOLETE] Switched from bionic to focal on Travis CI (we've switched to GH actions after that).
@brunobord brunobord mentioned this issue Nov 13, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setup py to cfg fixes workalendar/workalendar
1 participant
@brunobord