Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift_exceptions does not prevent New Years Day (Observed) in some cases #610

Closed
paulpharr opened this issue Jan 7, 2021 · 2 comments · Fixed by #638
Closed

shift_exceptions does not prevent New Years Day (Observed) in some cases #610

paulpharr opened this issue Jan 7, 2021 · 2 comments · Fixed by #638
Labels
bug duplicate
Projects
Workalendar

Comments

@paulpharr
Copy link

When January 1 is on a Saturday (as it is in 2022), the United States calendar for the prior year (in this case 2021) has holiday New Years Day (Observed) on December 31 even when shift_exceptions contains an exception for January 1.

work holiday: 2021-12-31 [fri] - New Years Day (Observed)

shift_exceptions = ((1, 1),
                    (12, 25),
                    )
@brunobord
Copy link
Member

Looks like a duplicate of #200
I think I need to work on it this year. Stay tuned!

@brunobord brunobord added this to Warming up in Workalendar via automation Jan 8, 2021
@brunobord brunobord moved this from Warming up to To Do in Workalendar Jan 8, 2021
@brunobord brunobord moved this from To Do to Working in Workalendar Mar 5, 2021
brunobord added a commit that referenced this issue Mar 5, 2021
@brunobord
Bugfix: USA calendar would take the shift_exceptions, even if the e…
35d23d4 
…xceptions are set "next/previous year"

refs #610
brunobord added a commit that referenced this issue Mar 5, 2021
@brunobord
Bugfix: USA calendar would take the shift_exceptions into account, …
5d56069 
…even if the exceptions are set "next/previous year"

refs #610
brunobord added a commit that referenced this issue Mar 5, 2021
@brunobord
Bugfix: USA calendar would take the shift_exceptions into account, …
15c6735 
…even if the exceptions are set in the next or previous year

refs #610
@brunobord brunobord mentioned this issue Mar 5, 2021
Merged
2 tasks
brunobord added a commit that referenced this issue Mar 5, 2021
@brunobord
Bugfix: USA calendar would take the shift_exceptions into account, …
5953780 
…even if the exceptions are set in the next or previous year

refs #610
brunobord added a commit that referenced this issue Mar 5, 2021
@brunobord
Bugfix: USA calendar would take the shift_exceptions into account, …
ac1a57d 
…even if the exceptions are set in the next or previous year

refs #610
brunobord added a commit that referenced this issue Mar 5, 2021
@brunobord
v15.0.2
bbd26b5 
- Bugfix: USA calendar would take the `shift_exceptions` into account, even if the exceptions are set in the next or previous year (#610).
- Requirements: Unpin `pyupgrade` library (#634).
@brunobord brunobord mentioned this issue Mar 5, 2021
Merged
14 tasks
Workalendar automation moved this from Working to Done Mar 5, 2021
@brunobord
Copy link
Member

you may try to upgrade to the 15.0.2, hopefully, it includes a fix to your issue.

@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug duplicate
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v15.0.2 workalendar/workalendar
2 participants
@brunobord @paulpharr