Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_working_days_delta doesn't integrate the extra_holidays and extra_working_days args #631

Closed
brunobord opened this issue Feb 26, 2021 · 1 comment · Fixed by #641
Closed

get_working_days_delta doesn't integrate the extra_holidays and extra_working_days args #631

brunobord opened this issue Feb 26, 2021 · 1 comment · Fixed by #641
Labels
bug
Projects
Workalendar

Comments

@brunobord
Copy link
Member

they should be passed along, as we do in add_working_days and others.
@brunobord brunobord added the bug label Feb 26, 2021
@brunobord brunobord added this to Warming up in Workalendar via automation Feb 26, 2021
@brunobord brunobord moved this from Warming up to To Do in Workalendar Feb 26, 2021
@brunobord
Copy link
Member Author

found via #628

@brunobord brunobord moved this from To Do to Working in Workalendar Mar 12, 2021
brunobord added a commit that referenced this issue Mar 12, 2021
@brunobord
Bugfix: get_working_days_delta method to integrate the `extra_holid…
9c74529 
…ays` and `extra_working_days` args

refs #631
@brunobord brunobord mentioned this issue Mar 12, 2021
Merged
2 tasks
brunobord added a commit that referenced this issue Mar 12, 2021
@brunobord
Bugfix: get_working_days_delta method to integrate the `extra_holid…
5b22118 
…ays` and `extra_working_days` args

refs #631
@brunobord brunobord moved this from Working to Merged in Workalendar Mar 12, 2021
@brunobord brunobord mentioned this issue Mar 12, 2021
Merged
14 tasks
Workalendar automation moved this from Merged to Done/Closed/Published Mar 12, 2021
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v15.1.0 workalendar/workalendar
1 participant
@brunobord